Comments (26)
+1
Would be awesome if we didn't need to restart Prometheus to re-read configs and consoles
from prometheus.
I'm likely to get to this in the next few weeks.
from prometheus.
@brian-brazil That'd be awesome. Now restart prometheus automatically by using https://github.com/docker-infra/prometheus-consul and I hope I won't run into issues for now.
from prometheus.
I haven't touched this since then unfortunately.
from prometheus.
@fabxc will likely work on this as part of his internship.
from prometheus.
This will probably be on hold until service discovery is done, though - unless it's considered super urgent.
from prometheus.
How do you guys want to do service discovery? :)
from prometheus.
http://prometheus.io/docs/introduction/roadmap/#support-for-more-types-of-service-discovery is the roadmap entry. We are in the design state right now.
from prometheus.
We'll also want to reload the config on SIGHUP
. Not all file systems (natively) support watches.
from prometheus.
I would even prefer to have disk watches be optional. I'd much prefer explicit SIGHUPs in many cases (e.g. when I can't guarantee that the config file is replaced atomically).
from prometheus.
👍 on having both
@fabxc: If SD will integrate easily with consul and have a way to use the consul tag as label value, I don't really need the config reload anymore. Otherwise it would be more important to me to get the config reload first.
from prometheus.
I'm in the same position as @discordianfish - would prefer just having SD first, but config refresh would let me brew my own workaround at least.
from prometheus.
@levilovelock Just work-wise, it makes much more sense to get SD in order first as a base for implementing sane reloadable configs. Expect both soon[tm].
from prometheus.
We'll also want to reload changed rule files.
from prometheus.
We had a discussion that it might be better to reload only upon SIGHUP (which is implemented by now).
Does anybody feel a strong need for a file watch? If yes, I'd be willing to make the point against it.
Otherwise, I'll just close this.
from prometheus.
For configuration, a HUP is safest as it lets you do atomic changes.
from prometheus.
This work is great. I can use console-template or confd to handle config changes and fire the SIGHUP.
from prometheus.
As we don't apply bad config/rules it would work but so far we all agreed
that SIGHUP is the way to go.
On Thu, May 21, 2015 at 6:44 PM Dylan Meissner [email protected]
wrote:
This work is great. I can use console-template or confd to handle config
changes and fire the SIGHUP.—
Reply to this email directly or view it on GitHub
#108 (comment)
.
from prometheus.
👍 for SIGHUP only. If someone needs disk watches they can use a simple shell fragment like:
while inotifywait -e close_write prometheus.conf; do service reload prometheus; done
from prometheus.
Thanks for your feedback. Closing.
from prometheus.
I like the way nginx works.
nginx -t to test a config.
If the test succeeds then nginx -s reload to reload the config without restart.
This worths perfectly with confd and etcd combination.
from prometheus.
@mingfang That's pretty much how prometheus works: Use the promtool to check the config, then send prometheus a HUP signal.
from prometheus.
How often can I do reload?
What if I implement a custom server to manage rules, and it will send POST to /-/reload every time I edit and save a rule - can that impair Prometheus performance significantly if reloads will happen often (say, every minute)?
from prometheus.
Once a minute should be fine
from prometheus.
Good. Thanks!
from prometheus.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from prometheus.
Related Issues (20)
- Incorrect sum aggregations with recording rule HOT 2
- Flaky test TestDeletedSamplesAndSeriesStillInWALAfterCheckpoint
- prometheus_target_reload_length_seconds metric is given inconsistent labels HOT 1
- HIGH-Findings in Prometheus LTS-Version 2.45.3 HOT 1
- investigate the necessity of copying a mmap-ed chunk in ChunkDiskMapper
- Add OpenTelemetry to comparison doc HOT 3
- Feature Flag "Created Timestamps Zero Injection" requires enabled "Native Histograms" HOT 8
- Copiable pressed label set buttons in Prometheus Targets UI HOT 1
- Containerized scraping HOT 2
- quay.io lists v2.51.2 but i see no 2.51.2 release (with tarballs) on github HOT 2
- inotify inode leak in file discovery HOT 3
- Need urgent help!!! Want to modify tags "keys" to lowercase dynamically scraping from Cloudwatch-Exporter in Prometheus before sending to Mimir HOT 4
- improve --rules.max-concurrent-evals description. HOT 1
- Out of order exemplars when sending metrics using OpenTelemetry spanmetrics connector
- Some aggregations and functions produce incorrect results for native histograms HOT 4
- docker image does not recognise timezone appropriately HOT 1
- OOM crashloop auto-recovery
- discovery(scaleway): instances without private IPs are not added to the target lists
- protocol error: received DATA after END_STREAM HOT 3
- Prometheus does not recognize `HELP` and `TYPE` for OpenMetrics counters HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prometheus.