GithubHelp home page GithubHelp logo

Comments (4)

domenic avatar domenic commented on May 18, 2024

You're right, of course. The only objection is that promise libs might not get as much test coverage, if their create-fulfilled and create-rejected functions don't internally work by creating a pending first. I could go either way.

from promises-tests.

briancavalier avatar briancavalier commented on May 18, 2024

Can/should we provide default implementations for fulfilled and rejected for adapters that don't explicitly provide them? I.e. but still allow an adapter to provide them if it wants to?

from promises-tests.

domenic avatar domenic commented on May 18, 2024

Ooh, I kind of like that idea. Get better coverage if you want it, but not necessary.

from promises-tests.

ForbesLindesay avatar ForbesLindesay commented on May 18, 2024

I like that too

from promises-tests.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.