Comments (4)
You're right, of course. The only objection is that promise libs might not get as much test coverage, if their create-fulfilled and create-rejected functions don't internally work by creating a pending first. I could go either way.
from promises-tests.
Can/should we provide default implementations for fulfilled and rejected for adapters that don't explicitly provide them? I.e. but still allow an adapter to provide them if it wants to?
from promises-tests.
Ooh, I kind of like that idea. Get better coverage if you want it, but not necessary.
from promises-tests.
I like that too
from promises-tests.
Related Issues (20)
- 2.2.2.2 fails when resolving synchronously outside of .then's event-loop-turn HOT 12
- Help wanted: Own tests or promises-tests tests? HOT 4
- Test suite passes even if clause 2.3.2 is not implemented HOT 1
- Add test case for very nested promises HOT 1
- mocha test runner failures HOT 7
- Add tests for Promise.all and Promise.race. HOT 1
- Can you assist me in satisfying promises aplus spec 2.2.4 in NodeJS? HOT 2
- How to run tests at requirebin?
- "just create a pull request" HOT 2
- Allow to specify the timeout HOT 3
- Promise.prototype.finally tests HOT 1
- resolve then reject miss test case
- 2.3.3 numberOfTimesThenWasRetrieved should not increment in then getter HOT 1
- Please create 1.x branch
- is it still useful? HOT 5
- NPM complains about security issues HOT 1
- RFE: Clarify intent re resolve(promise) HOT 1
- 2.3.3.js `x` is an object with normal Object.prototype
- Error `require`ing adapter file D:\my-promise\my-promise.js HOT 1
- what the purpose of these code is in file 2.1.2.js?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from promises-tests.