Comments (7)
@edude03 could it be because of #13?
from pronto-reek.
ugh..seems like it- can we make this configurable?
from pronto-reek.
@dstull sure, go ahead, I'd be open to a PR implementing it 😄
from pronto-reek.
hmm, I was just looking into doing that...but I'm more of the opinion that #13 should be reverted. The whole point of using this is to be made aware of possible issues, if ran manually and automatically. If someone wants to mute a reek smell, then they should exclude it in their .reek file or inline...not here.
from pronto-reek.
@dstull is this still an issue?
from pronto-reek.
@ashkulz i have since changed jobs, and no longer use it. So not for me, but maybe for others if they use this.
from pronto-reek.
Hey guys, I bumped into this issue today! I'm using pronto (with pronto-reek) along with git-hooks managed by Overcommit. Overcommit is unfortunately swallowing errors coming from pronto-reek since it does not return an error code 😢 (see sds/overcommit#754)
from pronto-reek.
Related Issues (9)
- Does not use .reek configuration HOT 1
- Pronto-reek comments on files that are in exclude_paths HOT 4
- Please update to support pronto 0.3.0 HOT 1
- New Reek violations may not be reported HOT 5
- new release 0.11.1 HOT 1
- Breaks with reek v2.0.2 HOT 2
- passing reek command line options (-U) HOT 4
- upgrade pronto-reek to reek 3.3.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pronto-reek.