Command denote-dired-rename-file-and-add-front-matter does not add front matter about denote

[protesilaos]

What happens if you (require 'subr)?

[hpgisler]

(require 'subr)

enters debugger:

Debugger entered--Lisp error: (error "Loading file /usr/share/emacs/28.1/lisp/subr.elc f...")
  require(subr)
  (progn (require 'subr))
  eval((progn (require 'subr)) t)
  elisp--eval-last-sexp(nil)
  eval-last-sexp(nil)
  funcall-interactively(eval-last-sexp nil)
  call-interactively(eval-last-sexp nil nil)
  command-execute(eval-last-sexp)

Messages buffers says:

progn: Loading file /usr/share/emacs/28.1/lisp/subr.elc failed to provide feature ‘subr’

[protesilaos]

Okay, the problem is that on Emacs 28 this was (require 'subr-x).

EDIT: I thus plan to make this change, if you confirm it works:

 denote.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/denote.el b/denote.el
index 2152c69..00e264b 100644
--- a/denote.el
+++ b/denote.el
@@ -96,7 +96,9 @@ ;;; Commentary:
 ;;; Code:
 
 (require 'seq)
-(eval-when-compile (require 'cl-lib))
+(eval-when-compile
+  (require 'cl-lib)
+  (require 'subr-x))
 
 (defgroup denote ()
   "Simple notes with an efficient file-naming scheme."

[hpgisler]

Hmm, still the exact same error...

What I've done:

• I've modified denote.el according to your diff above
• I've deleted the compiled version, i.e. denote.elc from my filesystem
• I've restarted emacs

[protesilaos]

I found it by testing these two on emacs -Q with Emacs 28:

;; this has an error
(when-let* ((name (buffer-name)))
  (message "%s" name))

;; this works
(when-let ((name (buffer-name)))
  (message "%s" name))

The when-let* is legacy code anyway, as we only have one form and don't need the asterisk.

Pushed the change in commit 61e672f

[hpgisler]

Great, it now works!

Thank you, Prot!

[hpgisler]

Note:

There seem to be a couple of other when-let* in other files.
They should also be changed, shouldn't they?

[protesilaos]

Great, it now works!

Very well!

Thank you, Prot!

You are welcome!

There seem to be a couple of other when-let* in other files. They should also be changed, shouldn't they?

I checked them. The asterisk they have is correctly used in those cases. I will still need to require subr-x the way I mentioned before.

[protesilaos]

Closing this as it is continued in issue 74.