Comments (6)
Thanks @virtualjj working through checks 3.x now, I'll keep you posted
from prowler.
Cool - I'm slowing going through each control but I'm finding issues with the actual CIS recommendations. For example this filter will actually return a bunch of hits from the following AWS services:
kms.amazonaws.com
elasticloadbalancing.amazonaws.com
s3.amazonaws.com
acm.amazonaws.com
cloudtrail.amazonaws.com
cloudtrail.amazonaws.com
rds.amazonaws.com
logs.amazonaws.com
acm.amazonaws.com
ec2.amazonaws.com
iam.amazonaws.com
Especially kms.amazonaws.com if control 2.7 (Encrypted CloudTrail Logs) is enabled.
I think this metric filter below is actually better to reduce false positives but I have opened a support case with AWS to confirm:
{ $.userIdentity.sessionContext.attributes.mfaAuthenticated != "true" && $.eventSource != *.amazonaws.com }
UPDATE: AWS has acknowledged this issue (Case 1909332871) and will contact their teams to review the CIS white paper. This filter pattern has been suggested instead:
{ ($.additionalEventData.MFAUsed = "No") && ($.eventName = "ConsoleLogin") }
from prowler.
Thanks @virtualjj. Are you using something to implement all these changes? I mean, commands or a CFN template? I have found a template here that may create some alarms but it is not fully covering all CIS 3.X checks. https://s3-us-west-2.amazonaws.com/awscloudtrail/cloudwatch-alarms-for-cloudtrail-api-activity/CloudWatch_Alarms_for_CloudTrail_API_Activity.json
from prowler.
Awesome - thanks for this. I'm actually doing the changes with my own scripts but once I have everything cleaned up, planning on sharing my templates on GitHub.
from prowler.
That would be great. I'm also thinking to make public content here or write an blog post about how to fix all these WARNINGS with real commands or assets since what it comes in the CIS document is very vague. If you are interested let me know and we can put them toguether. I will keep you posted about my work on that template in the next days.
from prowler.
Sounds great - just followed you on Twitter. Not sure how quick I can contribute but will throw ideas your way in the meantime! Will close this issue - thanks again!
from prowler.
Related Issues (20)
- Allow secrets to be output when explicitly asked for using a flag HOT 3
- [Bug]: prowler azure is not scanning virtual machines in azure HOT 2
- [Bug]: iam_user_console_access_unused.py checks for last password usage HOT 3
- [Bug]: Prowler killed by OOM killer when run in AWS CloudShell HOT 6
- [Feature Request] - Round Robin the base urls in the event of unavailability for indexers HOT 1
- [Bug]: Cross account sqs flagged as public/critical HOT 3
- [Bug]: Exception merging from "*" and specific account HOT 3
- [Bug]: False positive on check - "Check if SQS queues have policy set as Public" HOT 2
- Improve publicly accessible checks to include targets of ELBs HOT 7
- [Bug]: Website Down? HOT 1
- [Bug]: False positve on ec2_securitygroup_not_used with Batch Compute HOT 6
- Support py3.12 HOT 1
- [Bug]: cloudwatch_log_group_retention_policy_specific_days_enabled alert on AWS managed log group HOT 4
- Possibility to custom output file using quick inventory HOT 1
- [Bug]: Output issue HOT 9
- [Bug]: False positive on s3_bucket_policy_public_write_access HOT 1
- [Bug]: allow list reporting wrong findings HOT 3
- [Question]: AWS account security questions have been deprecated HOT 3
- [Question]: Remove S3 KMS check, since its enabed by default, and cant be disabled HOT 2
- [Bug]: The assumed role ARN contains a value for resource type different than role, please input a valid ARN HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prowler.