GithubHelp home page GithubHelp logo

Comments (4)

n4ch04 avatar n4ch04 commented on May 28, 2024

Hi @Fennerr,
It makes sense, since the check metadata explicitly specifies If no authorizer is enabled anyone can use the service. so authorization can be handled at API scope or method scope.
I think I'm gonna store the method configuration in the apigateway service, and then the check logic would be:

if rest_api.authorizer:
    report.status = "PASS"
elif all methods authorized:
   report.status = "PASS"
else:
   report.status = "FAIL"

If a single method is not authorized and there is no API authorizer configured it would generate a FAIL

What do you think?

from prowler.

n4ch04 avatar n4ch04 commented on May 28, 2024

Please @Fennerr test the proposed solution and let us know if it works

from prowler.

Fennerr avatar Fennerr commented on May 28, 2024

Hi @n4ch04 - this does seem like a good approach - the only thing I would add is maybe skipping authorization checks on OPTIONS calls. Im a bit busy today, but Ill give it a go tomorrow and report back

from prowler.

n4ch04 avatar n4ch04 commented on May 28, 2024

Ok, please check it and let us know, we can add the OPTIONS http method handling

from prowler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.