GithubHelp home page GithubHelp logo

Comments (12)

jmanduca-psfy avatar jmanduca-psfy commented on May 24, 2024 1

This new OCSF-JSON does not include the Compliance Info, which was previously included in the previous JSON option. It is a requirement for the Compliance Finding [2003] Class but not in the Detection Finding [2004] Class which appears to be in use per @pr3l14t0r .
We were using this field to help sort through findings for our compliance requirements, now that it is gone it will create additional work or duplication of scans to sort them out in this version.

from prowler.

jfagoagas avatar jfagoagas commented on May 24, 2024 1

@pr3l14t0r we decided to use Detection Finding since it is the most accurate event for a Prowler finding. Regarding compliance we are evaluating the option to generate a Compliance Finding since as it happens with Prowler outputs, compliance and findings cannot be mapped into the same output.

CC: @jmanduca-psfy

from prowler.

jfagoagas avatar jfagoagas commented on May 24, 2024 1

@pr3l14t0r @jmanduca-psfy We are going to include the JSON v3 Compliance key in the Detection Finding at unmapped.compliance probably tomorrow. Sorry for the incovenience.

from prowler.

jfagoagas avatar jfagoagas commented on May 24, 2024 1

#3753

CC: @pr3l14t0r @jmanduca-psfy

from prowler.

jmanduca-psfy avatar jmanduca-psfy commented on May 24, 2024 1

Working great, thank you @jfagoagas !

from prowler.

adv4000 avatar adv4000 commented on May 24, 2024

Same issue here, Version 4.0.1 removed support for HTML:

prowler aws -M html
prowler aws: error: argument --output-formats/--output-modes/-M: invalid choice: 'html' (choose from 'csv', 'json-asff', 'json-ocsf')

from prowler.

jfagoagas avatar jfagoagas commented on May 24, 2024

Hi @jmanduca-psfy @adv4000, since v4 we have been deprecated the following outputs:

  • The HTML is replaced for the new Prowler Dashboard, you can try it with prowler dashboard.
  • The native JSON is replaced for the JSON OCSF v1.1.0, common for all the providers.

Thanks for using Prowler 🚀

from prowler.

christiandavilakoobin avatar christiandavilakoobin commented on May 24, 2024

I tried the dashboard, and is very handy, but it requieres some extra steps to view the results. The html version was very useful for a quick view.

from prowler.

pr3l14t0r avatar pr3l14t0r commented on May 24, 2024

@jfagoagas Thanks for that information, i have absolutely overseen the prowler dashboard functionality.

Quick question if allowed: Is there a reason why you/the team have chosen the Detection Finding [2004] Class over Compliance Finding [2003] Class in OCSF-JSON? I can't find a discussion for that anywhere.

from prowler.

pr3l14t0r avatar pr3l14t0r commented on May 24, 2024

@jfagoagas Thanks for the explanation, highly appreciated! :)

from prowler.

jfagoagas avatar jfagoagas commented on May 24, 2024

@jfagoagas Thanks for the explanation, highly appreciated! :)

It's nothing! Always here to help 🙌

from prowler.

jfagoagas avatar jfagoagas commented on May 24, 2024

We are going to close this issue once the above PR gets merged. Please let us know if everything works fine and feel free to reopen it if notice something not expected.

Thanks for using Prowler 🚀

from prowler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.