[Bug]: 'NoneType' object has no attribute 'client' with Prowler 4.2.1 about prowler

[christiandavilakoobin]

You're right. It works now! Thanks!

[jfagoagas]

Hi @christiandavilakoobin I've created the above PR in the branch PRWLR-3837-bug-none-type-object-has-no-attribute-client-with-prowler-4-2-1-4141. Please test it and tell me if this works as expected.

Thanks for using Prowler 🚀

[christiandavilakoobin]

Hi @jfagoagas,

Yes, it's working now.

Thanks!

[jfagoagas]

Hi @jfagoagas,

Yes, it's working now.

Thanks!

That's great! I'll fix some failing tests tomorrow and include some others to prevent this to happen again. Probably we will release a 4.2.2 tomorrow or Monday.

Thanks again 🙌

[jfagoagas]

Hi @christiandavilakoobin could you please test it again with the same branch? I've refactor some parts of the code make it more simpler to work with and also to separate concerns about AWS and other providers.

More tests has been included.

[christiandavilakoobin]

Hi @jfagoagas

It fails 😢 :

Traceback (most recent call last):
  File "/home/prowler/.local/bin/prowler", line 8, in <module>
    sys.exit(prowler())
             ^^^^^^^^^
  File "/home/prowler/.local/lib/python3.12/site-packages/prowler/__main__.py", line 204, in prowler
    global_provider.mutelist = args.mutelist_file
    ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/prowler/.local/lib/python3.12/site-packages/prowler/providers/aws/aws_provider.py", line 322, in mutelist
    mutelist = get_mutelist_file_from_lambda(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: get_mutelist_file_from_lambda() takes from 1 to 2 positional arguments but 3 were given

[jfagoagas]

You were faster than me! I'm just including tests for that part to prevent this from happening again.

[jfagoagas]

@christiandavilakoobin pushed changes and tests, thanks!

[christiandavilakoobin]

@jfagoagas same error. It seems you fixed the s3, but lambda still have 3 parameters instead 2.

[jfagoagas]

It should be fixed with the last commit maybe you didn't pull, could you check it?