Comments (10)
You're right. It works now! Thanks!
from prowler.
Hi @christiandavilakoobin I've created the above PR in the branch PRWLR-3837-bug-none-type-object-has-no-attribute-client-with-prowler-4-2-1-4141
. Please test it and tell me if this works as expected.
Thanks for using Prowler 🚀
from prowler.
Hi @jfagoagas,
Yes, it's working now.
Thanks!
from prowler.
Hi @jfagoagas,
Yes, it's working now.
Thanks!
That's great! I'll fix some failing tests tomorrow and include some others to prevent this to happen again. Probably we will release a 4.2.2 tomorrow or Monday.
Thanks again 🙌
from prowler.
Hi @christiandavilakoobin could you please test it again with the same branch? I've refactor some parts of the code make it more simpler to work with and also to separate concerns about AWS and other providers.
More tests has been included.
from prowler.
Hi @jfagoagas
It fails 😢 :
Traceback (most recent call last):
File "/home/prowler/.local/bin/prowler", line 8, in <module>
sys.exit(prowler())
^^^^^^^^^
File "/home/prowler/.local/lib/python3.12/site-packages/prowler/__main__.py", line 204, in prowler
global_provider.mutelist = args.mutelist_file
^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/prowler/.local/lib/python3.12/site-packages/prowler/providers/aws/aws_provider.py", line 322, in mutelist
mutelist = get_mutelist_file_from_lambda(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: get_mutelist_file_from_lambda() takes from 1 to 2 positional arguments but 3 were given
from prowler.
You were faster than me! I'm just including tests for that part to prevent this from happening again.
from prowler.
@christiandavilakoobin pushed changes and tests, thanks!
from prowler.
@jfagoagas same error. It seems you fixed the s3, but lambda still have 3 parameters instead 2.
from prowler.
It should be fixed with the last commit maybe you didn't pull, could you check it?
from prowler.
Related Issues (20)
- No data available Check the data folder to see if the files are in the correct format (prowler publish with public ip) HOT 1
- Time format changed between 4.2.4 and 4.3? HOT 9
- Mutelist pattern HOT 2
- Does scanning with a mutelist cause reports to no longer render counts/filter button? (v3.11.2) HOT 1
- Add AWS Performance Pillar Framework HOT 1
- check id "iam_root_hardware_mfa_enabled" PASS for virtual MFA device! HOT 7
- No file output despite successful aws scan HOT 1
- Report Security Groups that are not attached to any instances HOT 2
- Allow Prowler to be installed just for an specific provider HOT 2
- Add number of muted findings in HTML report HOT 2
- iam_role_cross_service_confused_deputy_prevention remediation broke specific process HOT 4
- AttributeError during output generation HOT 9
- Confused Deputy Attack finding for AWS EKS service HOT 1
- cis_2.1_azure incorrect checks resulting in incorrect outputs HOT 1
- Check to see if IAM Users or Roles have Administrator access HOT 4
- Conflicting documentation for mutelist tags on AWS HOT 6
- Execution Failure 'str' object has no attribute 'items' HOT 4
- New check to ensure that a group has not administrative privileges HOT 2
- Slack integration for critical medium high low mute alerts
- rds_instance_certificate_expiration reports failed on compliant resource
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prowler.