Ignore Invalid SSL certificate? about proxykit

[damianh]

@datvm I'm not going accept this proposal as I don't want the library to (accidentally) encourage the developer to perform a dangerous operation.

If you really need to do this, you can do so by configuring the http client:

services.AddProxy(httpClientBuilder =>
{
    httpClientBuilder.ConfigurePrimaryHttpMessageHandler(() => new HttpClientHandler
    {
        ServerCertificateCustomValidationCallback = (_, __, ___, _____) => true
    });
});

Note: this is not official guidance. You are responsible for your code if you ship this to production.

[datvm]

I have added an option for this. Sorry I didn't understand how Pull Request works, so I accidentally push it in my fork's master branch. Now my pull request has both code of #74 and #75. This added option does require the previous fix though.

How to use:

            services.AddProxy(configureOptions: options =>
            {
                options.IgnoreSSLCertificate = true;
            });

Or

            services.AddProxy();
            services.Configure<ProxyOptions>(options => options.IgnoreSSLCertificate = true);

I do not understand your UnitTest yet, so please help me write a Test for it. I myself test with my own project already and it is working well.

Sorry again for the messed up Pull Request.

[damianh]

I'm not sure about this - feels like we need a better way that doesn't enable a user to accidentally ship that to production (which would be really bad).

To do two separate PRs do the changes on two separate branches.

[datvm]

The default value is false so they can use #if DEBUG or Environment settings if they are intended for dev only. As for me, I need it for Production (the scenario I described above) as the request comes from localhost.

Or I can help adding whitelisted origins instead of blindly accept everything?