AndroidX compatibility (Cannot read property 'Builder' of undefined) about nativescript-inappbrowser

[jdnichollsc]

ok guys, I'm going to publish a new version with other changes, let me do that at night 👍

[jdnichollsc]

Let me see tomorrow 👍

[sulymkaa]

@jdnichollsc , I tried to do it, but nothing has changed( are you ok after your bike accident?

[jdnichollsc]

@sulymkaa thanks for asking, I'm feel better 😅

[tgpetrov]

@jdnichollsc The configuration looks good.
However, I believe this line can break the backwards compatibility. Maybe you can use the CustomTabsIntent const that you creating on the next line, instead of hardcoding the androidx.browser.customtabs.CustomTabsIntent path?

[jdnichollsc]

Ohh but it's only for types, how can you create a type using a variable? 🤔

[tgpetrov]

Aah, I see. Yes, you are right, should be ok the way it is now.

[jdnichollsc]

let me check, thanks mate!

[jdnichollsc]

@sulymkaa do you know if you can use jetifier to fix that? I want to avoid breaking changes :/

[jdnichollsc]

Nevermind, that only works for native code directly 😅

[tgpetrov]

Actually, plugins can support androidx without braking changes. There is a "Make it Compatible with Both Support-lib and AndroidX" section in this blog post.

[sulymkaa]

@jdnichollsc would you be able to make update according to migration post?

[sulymkaa]

@jdnichollsc , could you please let me know when you are going to push an update please?

[adfdev]

for the moment have migrate with this tool , folder in node_modules

[jdnichollsc]

Sorry for the delay guys, yesterday I had an accident in my motorcycle, let me do this today 👍

[jdnichollsc]

guys, do you know if I can avoid breaking changes by doing this from include.gradle?

dependencies {
    def supportLibVersion = null
    if (project.hasProperty('supportLibVersion')) {
        supportLibVersion = project.supportLibVersion
    } else if (project.hasProperty('supportVersion')) {
        supportLibVersion = project.supportVersion
    }
    if (supportLibVersion) {
      implementation "com.android.support:customtabs:$supportLibVersion"
    } else {
      implementation 'androidx.browser:browser:1.+'
    }
}

Let me know what you think 👍

[jdnichollsc]

Hi guys, please check the last changes from the demo of this repo and also, let me know what you think about this configuration https://github.com/proyecto26/nativescript-inappbrowser/blob/master/src/platforms/android/include.gradle#L14

[jdnichollsc]

You can see the types of both here https://github.com/proyecto26/nativescript-inappbrowser/blob/master/src/types/android.d.ts

[jdnichollsc]

Cool, I only have a little issue I want to fix before to publish the new version of the plugin... I want to be able to disable the animation when the SafariViewController is closed but I don't know how to do that, here https://github.com/proyecto26/nativescript-inappbrowser/blob/master/src/InAppBrowser.ios.ts#L189

Any help is really appreciated 😅

[sulymkaa]

@jdnichollsc could you please tell me how I can build this myself to test, or may be you can email me builded archive? Thanks!

[jdnichollsc]

mmm ok I'm going to publish the new version today, maybe the animation issue is a bug of the SafariViewController and I can fix that later as a minor change

[jdnichollsc]

Guys, I need help to fix the build issues in order to publish the new version, any help is really appreciated 👍 https://travis-ci.org/proyecto26/nativescript-inappbrowser

[jdnichollsc]

Done! https://github.com/proyecto26/nativescript-inappbrowser/releases/tag/v2.0.0