GithubHelp home page GithubHelp logo

Comments (5)

rkapka avatar rkapka commented on September 25, 2024 1

Hi @v4lproik , I assigned it to you. Thanks a lot for volunteering!

from prysm.

v4lproik avatar v4lproik commented on September 25, 2024

Hi! I would love to take this up :)

from prysm.

v4lproik avatar v4lproik commented on September 25, 2024

@geldmon, could you please share your output? It appears that the command you provided in the description produces the intended output as the 'goerli' flag is not passed to prysm.sh.

It seems that the environment flag is being correctly taken into account when passed as parameter.

While investigating, I realised that there's no test coverage for the piece of code formatting the beaconchaURL for goerli. I added some tests for that and also included support for Sepolia and Holesky.

from prysm.

geldmon avatar geldmon commented on September 25, 2024

I didn't pass the flag, that's fine then.
Lastly, I wonder if this shouldn't be attainable already during the exit process (i.e when calling beacon node)

from prysm.

prestonvanloon avatar prestonvanloon commented on September 25, 2024

Fixed by #13308

from prysm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.