GithubHelp home page GithubHelp logo

Comments (11)

rauljordan avatar rauljordan commented on June 5, 2024

The only thing we haven't really been following is the commit message structure. Let's make sure everyone on the team is on the same page.

from prysm.

terencechain avatar terencechain commented on June 5, 2024

Web3.py and py-evm's commit message structure:

  • What was wrong?
  • TODO
  • How was it fixed?
  • Cute Animal Picture

from prysm.

terencechain avatar terencechain commented on June 5, 2024

Vyper's commit message structure:

  • What I did
  • How I did it
  • How to verify it
  • Description for the changelog
  • Cute Animal Picture

from prysm.

terencechain avatar terencechain commented on June 5, 2024

Solidity doesn't have a commit message structure, it refers to issue

from prysm.

terencechain avatar terencechain commented on June 5, 2024

Casper's commit message structure:

  • Issue
  • Proposed implementation

from prysm.

prestonvanloon avatar prestonvanloon commented on June 5, 2024

I reached out to the folks at ethereum/go-ethereum to get a copy of their gitcop configuration. I've also enabled gitcop (I think), but it might not be the same rules until I hear back.

I'll rebase all of our commit messages, but it will take a me a little while to do it since there are 3 months worth of messages that do not conform to the rule.

From now on, we must use the sharding: prefix to our commit messages.

from prysm.

terencechain avatar terencechain commented on June 5, 2024

from prysm.

prestonvanloon avatar prestonvanloon commented on June 5, 2024

Yeah, any clue how to do this properly? I tried git rebase -i bc76d3e96886cd2e354605bec40d326477090015 and changed the commit messages in the git-todo along with setting it to "reword", but it seems to have not reworded anything and just double signed all commits. master...prestonvanloon:forced-rebase

from prysm.

rauljordan avatar rauljordan commented on June 5, 2024

What do we need to get this closed? Do we just have to update all our previous commit msgs?

from prysm.

prestonvanloon avatar prestonvanloon commented on June 5, 2024

Yeah and enable gitcop. I have the settings from Peter in an email. If you know of an easy way to update all of the previous messages, let me know!

from prysm.

rauljordan avatar rauljordan commented on June 5, 2024

We will no longer be dependent on Geth. Closing.

from prysm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.