Comments (1)
Thanks for raising this.
First some background on why it works the way it does today. The CompressedBytes and TransferBytes are primarily there to show to the receiver before they accept a file (or directory) transfer, allowing them to reject files that may be too large. They are fields that are part of the offer sent by the sender via the rendezvous server for files and directories. This happens before a direct connection is made between the two clients. Text messages work a little differently. The full contents of the text message is stored encrypted in the mailbox on the rendezvous server. This means that there is no opportunity to reject the message before fully receiving its contents.
Given that one of the goals of the API was to be as consistent as possible between the different types of offers, I think its reasonable to populate these fields. However, I think we should clearly document that the for Text messages, the size is populated by fully receiving the message in memory and that you can't reject a text message at that point.
from wormhole-william.
Related Issues (20)
- Create a new release HOT 3
- support for queuing files ? HOT 1
- feature request: wormhole code completion HOT 4
- add interactive secret input? HOT 1
- Feature request: enable shell completions by default HOT 2
- Please provide linux builds with musl libc HOT 2
- Listen for transit protocol on the receiving side HOT 4
- Empty `message_ack` field in a `file_ack` message causes magic-wormhole.rs client to crash
- Upgrade nhooyr.io/websocket to get gin upgrade
- Add new gio File explorer, so that a user can pick a file on any OS HOT 1
- Transit relay hints encoding is wrong HOT 5
- Use peer's relay hints HOT 12
- 64-bit and ARM binaries for Windows HOT 5
- Hangs and crashes when sending empty files
- Low contrast font colors in a terminal emulator can make the QR codes unscannable (--qr). HOT 1
- Audit usages of runtime reflection HOT 5
- Distributing on npm HOT 7
- Upstreaming HOT 1
- Is it compatible with Android armv8a phones? HOT 14
- Update deps to avoid vulnerability. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wormhole-william.