GithubHelp home page GithubHelp logo

Kerberos support about requests HOT 21 CLOSED

psf avatar psf commented on June 20, 2024
Kerberos support

from requests.

Comments (21)

kennethreitz avatar kennethreitz commented on June 20, 2024

I'm looking into adding this, thanks for the suggestion!

from requests.

kennethreitz avatar kennethreitz commented on June 20, 2024

Someone was working on this, but I haven't heard from him in a while.

I'd love to see a requests-kerberos module that provides the auth handler.

from requests.

pnasrat avatar pnasrat commented on June 20, 2024

Was there a published tree with a starting point for this? Else if it's free I may take a stab.

from requests.

eichin avatar eichin commented on June 20, 2024

Release v0.13.4 includes this (just add auth=requests.auth.HTTPKerberosAuth() to the keyword args to requests.get()) so perhaps this can be closed now...

from requests.

kennethreitz avatar kennethreitz commented on June 20, 2024

🍰

from requests.

kcr avatar kcr commented on June 20, 2024

Said code appears to have been ripped out in 377078b

from requests.

kennethreitz avatar kennethreitz commented on June 20, 2024

correct, there is now a requests-keroberos project which will contain this functionality

https://github.com/requests/requests-kerberos

from requests.

kcr avatar kcr commented on June 20, 2024

Which doesn't work, and when fixed will continue to rot when you change an interface.

Which isn't packaged by anyone and will be that much more effort to get into e.g. debian or ubuntu.

Security should never be a secondary feature that you have to go to extra lengths to enable.

from requests.

kennethreitz avatar kennethreitz commented on June 20, 2024

The interface will never change. It was removed because I cannot maintain it.

from requests.

kcr avatar kcr commented on June 20, 2024

(I apologize if this is coming across a bit confrontational, but I was unreasonably annoyed by the functionality I was wanting and expecting being removed in a commit labelled "hooks and such")

from requests.

kennethreitz avatar kennethreitz commented on June 20, 2024

refactors are brutal :)

from requests.

kcr avatar kcr commented on June 20, 2024

I say this about interfaces from the perspective of having made the code work again; some of the details of how the response hook is called appears to have changed since it was written.

I appreciate that this sort of thing is hard to maintain, but that's a reason to say "hey can someone write me a test" not quietly delete it in the apparent hope that nobody notices.

from requests.

kennethreitz avatar kennethreitz commented on June 20, 2024

this was not quietly removed, requests was basically fully rewritten and stripped down of everything unnccesary.

http://kennethreitz.org/exposures/announcing-requests-v1-0-0

from requests.

kcr avatar kcr commented on June 20, 2024

Oops, I completely failed to find that. I apologize for my implication.

Still, authentication methods ought to be core functionality and tested along with everything else; anything more complex than Basic is going to end up having to fiddle around behind the scenes.

from requests.

kennethreitz avatar kennethreitz commented on June 20, 2024

The authentication interface and mechanism is a first-class citizen. Basic and Digest is all that will be supported in core.

from requests.

kcr avatar kcr commented on June 20, 2024

"Security is hard, batteries not included"

from requests.

kcr avatar kcr commented on June 20, 2024

Pull request for requests_kerberos sent.

from requests.

Lukasa avatar Lukasa commented on June 20, 2024

@kcr: The biggest problem requests-kerberos has is a lack of tests. If you want to contribute a test suite (or even just a couple of tests), that will greatly improve our ability to keep it up to date. =)

from requests.

eichin avatar eichin commented on June 20, 2024

@Lukasa I suspect we'll be able to repurpose at least the setup parts of the Zephyr test suite we're working on over the next couple of weekends, we'll definitely be in touch about that :)

from requests.

sigmavirus24 avatar sigmavirus24 commented on June 20, 2024

@eichin, link for the curious?

from requests.

sigmavirus24 avatar sigmavirus24 commented on June 20, 2024

Also, can we move this over to requests/requests-kerberos#1?

from requests.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.