Parameters are getting out of hand. about requests

[jgorset]

Interesting idea!

Are you thinking something along the lines of...

with requests.settings(path='http://example.org', timeout=10) as r:
    response = r.get('/path/to/file.txt')

...?

[kennethreitz]

Heh, neat path idea.

I was thinking:

with requests.settings(timeout=10, auth=('a', 'b'), proxies={'http': 'localhost:8080'}):
    requests.get('http://blah.com/', params={'x': 'y'})

[jgorset]

either way I think that's awesome.

[kennethreitz]

Let's do it :)

[kennethreitz]

Maybe this would be better:

with requests.settings(timeout=10, auth=('a', 'b'), proxies={'http': 'localhost:8080'}) as r:
    r.get('http://blah.com/')

This would escape the threading/processes issues.

[kennethreitz]

If there's a way to detect if someone's using as r, then I'm all for doing it now. Otherwise, I'm going to think about it for a while.

[pydanny]

My thought is always that explicit is better than implicit. And intuitiveness goes along with it. So then are context processors more explicit and are they intuitive?

This does look like a divergence from the intuitive aspect of Requests that I like so much. I can point other newbies at it and they just get it. I'm open to ideas, but keep in mind your audience. Use of context processors could be for advanced users, and be given appropriate documentation.

[kennethreitz]

Great points.

If I do decide to implement this, it would be supplementary. All of the functions will accept the same paramaters they do now as well.

[kennethreitz]

Maybe I'll hold off on this for now.

Currently, you can do the following

>>> with requests.settings(verbose=sys.stderr):
...    requests.get('http://httpbin.org/ip')
2011-06-23T21:23:18.422726   GET   http://httpbin.org/ip
<Response [200]>

>>> requests.get('http://httpbin.org/ip')
<Response [200]>

As an alternative to:

>>> requests.settings.verbose=sys.stderr
>>> requests.get('http://httpbin.org/ip')
2011-06-23T21:23:18.422726   GET   http://httpbin.org/ip
<Response [200]>

>>> requests.settings.verbose=None
>>> requests.get('http://httpbin.org/ip')
<Response [200]>

I love this.

Maybe, it would just be best to move proxies into the settings module instead of being required to be passed into each request function for now.

[kennethreitz]

Decided: current settings singleton use is a non-issue because request.settings should only manage (supplementarily) all-encompassing settings (timeouts, proxies, etc).

Auth Management still needs to be rethought.

[kennethreitz]

See #75 for Re: Proxy

[kennethreitz]

I'd also like to move all non-essential keyword arguments (timeout, proxies, cookies) into a well-documented and constient **kwargs again. This will solve the 'paramaters getting out of hand' issue.

Closed.