GithubHelp home page GithubHelp logo

v0.5 is backwards incompatible about requests HOT 6 CLOSED

psf avatar psf commented on July 2, 2024
v0.5 is backwards incompatible

from requests.

Comments (6)

umbrae avatar umbrae commented on July 2, 2024

IMO data should map to the query string for a GET.

Some more discussion here: http://stackoverflow.com/questions/978061/http-get-with-request-body

from requests.

kennethreitz avatar kennethreitz commented on July 2, 2024

This change was introduced because parameters are now mapped on all query types, instead of only GET/HEADs.

This leads to a much more consistent internal API, with less request-type branching.

params = querystring dict
data = body dict or bytes

from requests.

kennethreitz avatar kennethreitz commented on July 2, 2024

It should also be noted that data is not an available keyword on the get function, which should be the primary method of making GET requests.

@jgorset, are you using request.request directly? I view that as an internal-only function.

from requests.

jgorset avatar jgorset commented on July 2, 2024

@kennethreitz,

if request is an internal function, I don't think it should be defined in the api module. I'd argue that it's very useful, though.

from requests.

kennethreitz avatar kennethreitz commented on July 2, 2024

@jgorset, can you hop on freenode #python-requests?

from requests.

umbrae avatar umbrae commented on July 2, 2024

Re: params = querystring, data=request body for all methods, I like that even better. 👍

from requests.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.