Comments (6)
IMO data should map to the query string for a GET.
Some more discussion here: http://stackoverflow.com/questions/978061/http-get-with-request-body
from requests.
This change was introduced because parameters are now mapped on all query types, instead of only GET/HEADs.
This leads to a much more consistent internal API, with less request-type branching.
params
= querystring dict
data
= body dict or bytes
from requests.
It should also be noted that data
is not an available keyword on the get
function, which should be the primary method of making GET requests.
@jgorset, are you using request.request
directly? I view that as an internal-only function.
from requests.
if request
is an internal function, I don't think it should be defined in the api
module. I'd argue that it's very useful, though.
from requests.
@jgorset, can you hop on freenode #python-requests?
from requests.
Re: params = querystring, data=request body for all methods, I like that even better. 👍
from requests.
Related Issues (20)
- Upgrade idna to 3.7 for CVE-2024-3651 HOT 1
- not support HTTP2 header HOT 1
- requests.request does not check method parameter HOT 1
- Support usage of PKCS#11 Hardware Security Modules where applicable HOT 1
- Session.verify ignored if REQUEST_CA_BUNDLES is set; behaviour not documented. HOT 4
- Can't access trailers with the Request library HOT 1
- AttributeError: 'NoneType' object has no attribute 'setdefault' on environment proxies HOT 3
- Connection problems HOT 1
- Request not throwing requests.exceptions.InvalidSchema on custom HTTPAdapter HOT 3
- Requests roadmap HOT 5
- 2.32.0 sdist is missing `tests/certs` HOT 4
- Requests 2.32.0 Not supported URL scheme http+docker HOT 16
- breaking aws s3 usage with requests 2.32.0
- Not supported URL scheme http+docker KOLLA ANSIBLE HOT 1
- SSLV3_ALERT_HANDSHAKE_FAILURE after upgrade from 2.31.0 to 2.32.2 HOT 20
- SSLCertVerificationError - unable to get local issuer certificate HOT 5
- ERROR - Cannot set verify_mode to CERT_NONE when check_hostname is enabled HOT 1
- Enhance Error Messaging for Connection Failures
- Different default values for "allow_redirects" for HEAD http method HOT 4
- Multiple concurrent client certs broken with v2.32.3 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from requests.