Drag from the maximize/unmaximize button to out of Latte panel make it crash... about applet-window-buttons

[psifidotos]

?I don't understand. Can't you simply repaint it using PreviewButton::update() ? Or you're testing it?
My main idea is we should only create the buttons one time.

big story... and update() was the wrong turn... I had to dig into the KDecoration2 code and the themes code in order to understand the logic behind single created buttons from PreviewButton...

The design is the following: PreviewButton creates its own decoration and client instances. By updating the client values and the initializing again the decoration then the button paints itself properly without any need for explicit update()....

So now with the last commit changing states for the buttons e.g. OnAllDesktops,Maximized/Restore, Different color scheme, Pressed, Hovered etc. etc... only updating the client is needed and passing to m_button the mouse events... Painting is done from the theme side without signaling it...

So this was a success... :) and now applet is almost at a full featured state...

[trmdi]

Now I've understood how you make the animation runs. Very interesting !

[trmdi]

Hmm... It only happens with BreezeEnhanced, and SierraBreeze and when drag from the maximize/unaximize button.
I think I should close this until you enable that button by default. If it still happens, then I would reopen it.

[psifidotos]

please test again...
I cant reproduce with any of them..

also one more thing...
I think that the applet is almost ready, all settings I was thinking to support are present now in preferences

[trmdi]

Sorry, I meant "maximize/unmaximize" buttons.
You may have to repeat the steps several times.

[trmdi]

Another way to reproduce the bug is: quickly click on the maximize button repeatly

[psifidotos]

Ok I reproduced but there is a big chance that this is totally upstream...

[trmdi]

Before it crashes, I see that PreviewButtonItem::createButton() is called many times. A bit weird.

[psifidotos]

Before it crashes, I see that PreviewButtonItem::createButton() is called many times. A bit weird.

it isnt because I have no other way to update the buttons drawing based on client changes...
when the active window changes maximized/restore state all buttons are recreated...

[psifidotos]

note quite yet... it is still crashing rarely, probably because during button destroying an animation has ended yet...

[trmdi]

--recreations for maximize and pin buttons are
not needed anymore but color scheme updating
in not ready yet (it stills needs recreations)
to work properly)

I don't understand. Can't you simply repaint it using PreviewButton::update() ? Or you're testing it?
My main idea is we should only create the buttons one time.