Color of buttons is not always painted properly for Breeze themes about applet-window-buttons

[kupiqu]

That may be a problem with Aurora themes.

Not sure this will be useful for you, but perhaps you could give Sierra Breeze Enhanced a try (https://github.com/kupiqu/sierrabreezeenhanced). In its settings you can specify a Gnome style similar to Materia...

[psifidotos]

Awesome, thank you @trmdi for testing it! and thank you @psifidotos for the feature!

nice! That feature was puzzling in my head a lot of time! With Plasma 5.15 that will be more awesome because I will be able to provide a kwin script that informs Latte for touching windows, so if the user has choose a different color scheme for some apps then this apps will look consistent with the top bar. That is demonstrated through:

https://www.youtube.com/watch?v=QkPv0-tfsXk

notice that because kwrite has a reddish theme the top bar is colored accordingly..

Missing pieces from master:

1. The entire codepage is updated in order to be more readable and maintainable, both for qml and c++ parts
2. All applets will be offered through kde store, including Latte Spacer and new Latte Separator... that way will be improved also its use for plasma panels
3. Panel new coloring must become multi-screen aware
4. All the View Settings (old Dock/Panel settings) will be reorganized. The settings window will offer three states instead of two. Currently is (Basic/Advanced). In new settings it will be (Basic/Advanced/Extreme).
   Tweaks will be dropped and all its settings will be moved to appropriate tabs. I think that will be (Behavior/Appearance/Effects/Tasks)

Basic will be the current mode,
Advanced will be the current mode with some added options from Basic
Extreme will offer all the settings but not only that, the Settings window will be moved at the edge of the screen and it is height will use all the available screen height, something like the Deepin Control Center.

In View Settings it will offered also a way to hide completely the editMode background in order for the user to notice the difference of its settings (e.g. shadows, effects etc.) runtime comparing for example the contrast that settings provide based on the current underlying desktop background.

[psifidotos]

thank u!!!

@trmdi btw did you check the new advanced dock settings in git version? I haven't taken any feedback from community and I really like it

[psifidotos]

@trmdi happy new year to you too!!

[kupiqu]

Did you try setting the Decoration to Current? Or if you want to set it manually, set Decoration to SierraBreezeEnhanced

Not sure this will solve the issue, but it will pick the proper Decoration Style. I think you have a mix in Breeze perhaps, coming from my issue number 1 that you reported.

[trmdi]

It seems that the buttons' color does not depend on the background color, while the panel color (the background) changes between black and white/transparent. So there is always a case the color of buttons and panel is similar.

[psifidotos]

SierraBreezeEnhance

When you use Breeze as decoration theme do you have this issue?

[psifidotos]

I am asking because the Buttons applets is not painting anything... It passes to decoration theme the colorscheme and the decoration theme paints accordingly ...

So this is not a request for the Buttons applet but rather for SieraBreezeEnhanced developer to paint its buttons based on the colorscheme....

[trmdi]

SierraBreezeEnhance

When you use Breeze as decoration theme do you have this issue?

Yes, as I said in post#1.

[psifidotos]

Yes, as I said in post#1.

In the Buttons applet choose:
Theme: Breeze
Colors: Current

it doesnt update accordingly when needed with Latte git version?

[trmdi]

Yes, as I said in post#1.

In the Buttons applet choose:
Theme: Breeze
Colors: Current

it doesnt update accordingly when needed with Latte git version?

Yes. Latte git version: 74f80cd4

Latte settings:

[psifidotos]

Enable in Latte: Monochrome contents when panel is transparent

Does it help?

[trmdi]

Enable in Latte: Monochrome contents when panel is transparent

Does it help?

No, it doesn't:

[psifidotos]

No, it doesn't:

Enable in Latte: "Hide background for not maximized windows"

does it help?

[trmdi]

No, it doesn't:

Enable in Latte: "Hide background for not maximized windows"

does it help?

Neither. It works on your computer?

[psifidotos]

Neither. It works on your computer?

yes, I have no issues with this...

[psifidotos]

either way... this is a Latte issue.. open a bug report for Latte to keep record... it is probably some Latte settings combination that breaks it...

[psifidotos]

This is my layout if you want to test it:
MyLayout(x11).layout.latte.txt

Just remove the txt extension before importing

[trmdi]

Ok, I will do.
But do you think you should add a rectangle background with the right color from the colorscheme under the buttons preview in the config window?

[psifidotos]

background with the right color from the colorscheme under the buttons preview in the config window?

I am not sure that could work.. it would look ugly and not sure if it would provide always better contrast...

[trmdi]

This is my layout if you want to test it:
MyLayout(x11).layout.latte.txt

Just remove the txt extension before importing

Here is your layout, I don't know whether the color of the buttons is right or wrong:

[psifidotos]

They should be the same color with your applets

[psifidotos]

Are you using latest git version?

[trmdi]

Are you using latest git version?

Yes, both of them:

❯ zypper if latte-dock applet-window-buttons | grep -i version
Version        : 999.git.20181125.74f80cd4-95.1               
Version        : 999.git.20181124.da3d3d2-16.1

[trmdi]

either way... this is a Latte issue.. open a bug report for Latte to keep record... it is probably some Latte settings combination that breaks it...

I've opened it here: https://bugs.kde.org/show_bug.cgi?id=401431

[psifidotos]

@trmdi what is your Show option ?

[psifidotos]

@trmdi give it a retest please...

1. you must use latest Latte git version because I have added some changes that could help with this
2. and latest window buttons applet master version

[trmdi]

After upgrading, the color doesn't change from dark <-> white when I change the focus/(un)maximize windows, like the video I attached in the Latte bug report. Something has been improved.

But, the main bug still exists. It seems the button applet doesn't know the current color correctly.

[psifidotos]

But, the main bug still exists. It seems the button applet doesn't know the current color correctly.

applet does not paint anything, it just passes the color scheme file to the decoration to paint itself...
let's try and see what color file is passed...

1. run latte from a terminal with 'latte-dock -d'
2. what is the terminal output when playing with this?

[psifidotos]

dont worry I reproduced... it happens only with plasma pop ups...

[psifidotos]

for plasma pop ups I have to think it over how this could be solved it is a strange situation...

[psifidotos]

@trmdi ok I found a way... please retest with latest Latte git version and Buttons master version

[trmdi]

On my computer, it looks like the color of the buttons is inverted.

[debug 21:11:08.449449] - buttons scheme update to: "/tmp/lattedock-EHKYUh/reversed.colors"
[debug 21:11:08.453453] - buttons scheme update to: "/tmp/lattedock-EHKYUh/reversed.colors"
[debug 21:11:10.364364] - buttons scheme update to: "/usr/share/color-schemes/Breeze.colors"
[debug 21:11:10.368368] - buttons scheme update to: "/usr/share/color-schemes/Breeze.colors"
[debug 21:11:15.516516] - buttons scheme update to: "/tmp/lattedock-EHKYUh/reversed.colors"
[debug 21:11:15.521521] - buttons scheme update to: "/tmp/lattedock-EHKYUh/reversed.colors"

--- /tmp/lattedock-EHKYUh/reversed.colors	2018-12-09 19:17:37.384374940 +0700
+++ /usr/share/color-schemes/Breeze.colors	2018-11-27 23:05:53.000000000 +0700
@@ -35,14 +34,0 @@
-[Colors:Complementary]
-BackgroundAlternate=59,64,69
-BackgroundNormal=239,240,241
-DecorationFocus=30,146,255
-DecorationHover=61,174,230
-ForegroundActive=147,206,233
-ForegroundInactive=175,176,179
-ForegroundLink=61,174,230
-ForegroundNegative=231,76,60
-ForegroundNeutral=253,188,75
-ForegroundNormal=49,54,59
-ForegroundPositive=46,204,113
-ForegroundVisited=61,174,230
-
@@ -51 +37 @@
-BackgroundNormal=252,252,252
+BackgroundNormal=61,174,233
@@ -59 +45 @@
-ForegroundNormal=61,174,233
+ForegroundNormal=252,252,252
@@ -65 +51 @@
-BackgroundNormal=252,252,252
+BackgroundNormal=35,38,39
@@ -73 +59 @@
-ForegroundNormal=35,38,39
+ForegroundNormal=252,252,252
@@ -79 +65 @@
-BackgroundNormal=35,38,39
+BackgroundNormal=252,252,252
@@ -87 +73 @@
-ForegroundNormal=252,252,252
+ForegroundNormal=35,38,39
@@ -93 +79 @@
-BackgroundNormal=35,38,39
+BackgroundNormal=239,240,241
@@ -101 +87 @@
-ForegroundNormal=239,240,241
+ForegroundNormal=35,38,39
@@ -104,0 +91,14 @@
+[Colors:Complementary]
+BackgroundAlternate=59,64,69
+BackgroundNormal=49,54,59
+DecorationFocus=30,146,255
+DecorationHover=61,174,230
+ForegroundActive=147,206,233
+ForegroundInactive=175,176,179
+ForegroundLink=61,174,230
+ForegroundNegative=231,76,60
+ForegroundNeutral=253,188,75
+ForegroundNormal=239,240,241
+ForegroundPositive=46,204,113
+ForegroundVisited=61,174,230
+
@@ -107 +107 @@
-Name=Breeze_reversed
+Name=Breeze
@@ -114,6 +114,6 @@
-activeBackground=252,252,252
-activeBlend=75,71,67
-activeForeground=71,80,87
-inactiveBackground=189,195,199
-inactiveBlend=252,252,252
-inactiveForeground=239,240,241
+activeBackground=71,80,87
+activeBlend=252,252,252
+activeForeground=252,252,252
+inactiveBackground=239,240,241
+inactiveBlend=75,71,67
+inactiveForeground=189,195,199

[psifidotos]

Hm what is your plasma theme?

[psifidotos]

Reversed color scheme is used when the underlying background needs a scheme with higher contrast

[trmdi]

Hm what is your plasma theme?

The stock theme Breeze.
If I change it to Breeze Light (the stock theme too), it looks like this :|

[psifidotos]

totally related to Breeze...
I managed to reproduce, if you use other plasma theme e.g. Materia etc. etc. that provides its own color palette it should work just fine...

I will play with it to see what breaks for Breeze color scheme and Breeze plasma theme(s)

[psifidotos]

@trmdi ok found it...

both are bugs breeze colors schemes, they are setting their WM colors faulty...
try to load the color scheme from plasma light theme and you will understand what is happening...

So Latte probably should take into account this and update the WM records in the theme file accordingly when that color palette is used from a plasma theme

[psifidotos]

ok... this must have been fixed from: https://bugs.kde.org/show_bug.cgi?id=401431

[trmdi]

Ok, well done. Thank you !

[kupiqu]

@trmdi could you please test if it also works fine when using sierrabreezeenhanced with the following two options enabled

• inactive window button style
• match title bar to window background

when using it on a dark latte panel?

this is the only configuration that fails in my system: I (barely) see dark buttons over the dark background. But I am using stable latte-dock not master and would highly appreciate if you could tell me if it works fine (or not) when using master.

thanks in advance!

[trmdi]

could you please test if it also works fine when using sierrabreezeenhanced with the following two options enabled...

I don't see any problem.

[kupiqu]

Awesome, thank you @trmdi for testing it! and thank you @psifidotos for the feature!

[kupiqu]

Nice!

[trmdi]

Hey, I just want to say thank you for everything you've done. Happy new year!

[miyaokamarina]

@psifidotos, what about non-Breeze themes? I use Materia Dark, and it works great with dark windows, but makes buttons invisible with light ones. Non-Latte plasmoids have an option to enable shading (I use it for tray applet), but this applet does not allow it.

[psifidotos]

@miyaokamarina can you provide screenshots demonstrating the issue and what do you mean by shading as solution?

[miyaokamarina]

Here is my setup. I added two color picker applets to illustrate painting (both are with the same color; one with enabled “Enable painting for this applet” feature, other with disabled).

When Chrome window active (buttons invisible):

When Telegram window is active (buttons visible):

[psifidotos]

1. Are you using Plasma or Latte top panel?
2. If Latte, git or version 0.8?

[miyaokamarina]

1. That’s Latte panel.
2. I’m on git 971e67f6 version from archlinuxcn repo.

[psifidotos]

3. Have you installed and enabled the Latte Window Colors script?
4. Have you enabled at Window Buttons applet: Current?

[miyaokamarina]

Yes, I use Latte Window Colors. I can’t use Current option in Window Buttons. I use Breeze decorations in KWin, because it allows me to remove borders and titles (unlike Materia), but I use Materia Dark theme in Window Buttons applet. When I select Current/Breeze decorations in Window Buttons and Current colors, everything works fine ofc. Except that I don’t want Breeze icons. When I select Materia decorations in Window Buttons, I cannot anymore select Current colors.

[psifidotos]

Long story short, Aurorae themes like Materia Dark can NOT support dynamic coloring

[miyaokamarina]

@kupiqu, that looks great! It doesn’t exactly match Materia KDE theme, but looks good to me.

@psifidotos, I understand it, but if I understand correctly dynamic coloring may be supported for entire applet (like for all other non-Latte applets).

[psifidotos]

the problem is that Aurorae themes are svg or png files. So dynamic coloring is not possible, of course if someone appears with a magic patch supporting this I have no objection but I wouldn't bet on it

[kupiqu]

SVG files are XML files, so changing colors there is easy by match and replace. The problem is knowing which ones to change.

PNG files are an entirely different thing.

[miyaokamarina]

Both PNG and SVG may be titned with SVG filters like here.

[psifidotos]

Yeah ok... feel free then to send patches for review then