Comments (7)
Hm, I see.
Actually it was handled before with the option "c" that you have suggested. Take a look the "createImageUrl" function in this commit. As you can see there was a check "file_exists(fileTypeIcon)" and it worked good, but it produced 404 errors to browser console in case there was no icon found for file type. Not a good approach I believe. That why I have decided to read the whole list of icons from the filesystem, but you are right, it's not reliable way. There is option "d" - we can list all file types which have icons in config file, but of course it would be better to get the icons list dynamically somehow.
from richfilemanager.
Hi @servocoder, yes, the .png files in images/fileicons could be set as default. Only if no match in fileIcons (and no match e.g. in "notFoundFIs", see below) an ajax request (with timeout) would be triggered and the result set into fileIcons if found. Otherwise (404/ajaxError) the fileType is marked as not found in an array e.g. named "notFoundFIs". Then this test would applied before triggering. This is kind of incremental dynamic and may be I think the best we can get from the client side.
from richfilemanager.
I don't think we need any ajax requests if we are going to list all possible filetype icons (see images/fileicons) in the config file. If there is no match in the list then default icon is applied. Of course we should keep the list up to date, not so flexible though. Perhaps I misunderstood your idea. What do we need ajax requests for, in the case I have described?
from richfilemanager.
your are right, keep it simple, I agree!
from richfilemanager.
Hi @gmkll !
The issue is supposed to be fixed at the "dev" branch. I have moved all grid view icons paths to css, so there is no any conjuction with js side now. I would appreciate if you check it out and leave a feedback.
from richfilemanager.
I skimmed the current dev branch (new version, see below), but detected (or was stopped by) some changes after merge pull #49. I think there are changes on the backend side also (I not inspected all PHP changes). E.g. the (new) resourceobject is expected to have an"attributes" JSON object (was Properties, as still refered to in the API), an id (was Path?), which I never realized before, ....
I´m comparing, what was version 1.0.4 with current version 1.0.6, which is also mentioned in filemanager.config.default.json, but I think this has to be updated to at least version 1.0.7 now. To handle API (breaking!) changes I would suggest to add this versioning to the API as well, which should be consistent with (or mapped to) the version in the JSON file. Otherwise it would be difficult to understand, what´s new/changed.
I stopped at this point..
Sorry, if I missed something?
from richfilemanager.
Oh, you use Java conneсtor, how could I forget.
It will require some changes in terms of API responses. You could find the discussion about API standardization at #37. The good news is that responses for all requests now looks similar, so that it's much clear at the moment. Of course the new API should be well described, so I will do that and come back when it's ready. Thank you for your time.
from richfilemanager.
Related Issues (20)
- how to prevent right click event
- No thumbs HOT 3
- Excel Sheet file view and edit
- No thumbs in laravel project
- Flash file not able to upload HOT 1
- Cannot hook on Rename
- Can we expand all the folder from s3 using single request??? HOT 1
- Copy a folder create 0 byte file in S3
- Failed to resize image (original, thumbnail) on the server
- E_INVALID_PAR_TYPE error while loading HOT 2
- How can I hook into the download action? Is there a callback available?
- RichFilemanger Fails to run under IIS HOT 1
- Use RichFilemanger in .Net Core 3.1 project HOT 1
- Deleted
- Uncaught (in promise) ReferenceError: purl is not defined
- Load other client side configuration manually? (filemanager-config.json) HOT 2
- Preview URL some path items duplicated. HOT 1
- Next/Prev buttons in preview window
- Image broken when preview the uploaded image
- imagesx(): Argument #1 ($image) must be of type GdImage, bool given
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from richfilemanager.