Comments (2)
Hello,
Thanks for contacting me! I'd be very happy to accept a PR!
I'm not sure that ShowGui is the ideal place where to place such code, since the background drawing in not really related to the GUI.
After a quick look, I though it would perhaps be better to add custom callback inside src/hello_imgui/runner_callbacks.h near existing ones:
For example:
VoidFunction PreNewFrame = EmptyVoidFunction();
VoidFunction BeforeImGuiRender = EmptyVoidFunction();
VoidFunction AfterSwap = EmptyVoidFunction();
// add this?
VoidFunction CustomBackground = EmptyVoidFunction();
Note:
- the new callback should be documented at the top of the file, near the other
- it might be a good idea to add a note that refers to this callback next to the doc for
backgroundColor
inside src/hello_imgui/imgui_window_params.h
What do you think?
PS:
I like your hdrview project! It made me think of another project I wrote ImmVision, (part of "ImGui Bundle") although it does not handle hdr (it is more of an image processing debugger).
from hello_imgui.
Yes, that does sound like a better way to fit it in. I'll give it a try and let you know.
from hello_imgui.
Related Issues (20)
- Pre-exit behavior HOT 1
- An api which can help us get assets folder path HOT 2
- IDBFS Support HOT 1
- Imgui Ini Settings Parts HOT 2
- requrest:How to know which dockspace is currently active HOT 2
- not working on linux ubuntu HOT 1
- Some question about hello_imgui_ini_settings HOT 1
- How to set the no_docking and no_tab_bar for the MainDockSpace ? HOT 3
- Bisect MoveWindowToMonitor HOT 1
- macOS bundle support HOT 2
- Can I change a borderless window size? HOT 3
- Metal backend + emscripten favicon and shell template HOT 22
- Ability to put user menu items between the App Menu and the View Menu HOT 1
- Sdl Dpi awareness on Windows / multiple monitors HOT 1
- New back-end default HOT 3
- adding generated files to assets directory? HOT 8
- freetype dependency in Windows HOT 4
- how to add a toolbar (or other fixed windows) that limits the available main docking space? HOT 9
- Is there a way to make input_text to show only the last part of the text while deactivated HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hello_imgui.