GithubHelp home page GithubHelp logo

Comments (2)

pthom avatar pthom commented on June 7, 2024

Hello,

Thanks for contacting me! I'd be very happy to accept a PR!

I'm not sure that ShowGui is the ideal place where to place such code, since the background drawing in not really related to the GUI.

After a quick look, I though it would perhaps be better to add custom callback inside src/hello_imgui/runner_callbacks.h near existing ones:

For example:

    VoidFunction PreNewFrame = EmptyVoidFunction();
    VoidFunction BeforeImGuiRender = EmptyVoidFunction();
    VoidFunction AfterSwap = EmptyVoidFunction();

   // add this?
  VoidFunction CustomBackground = EmptyVoidFunction();

Note:

  • the new callback should be documented at the top of the file, near the other
  • it might be a good idea to add a note that refers to this callback next to the doc for backgroundColorinside src/hello_imgui/imgui_window_params.h

What do you think?

PS:

I like your hdrview project! It made me think of another project I wrote ImmVision, (part of "ImGui Bundle") although it does not handle hdr (it is more of an image processing debugger).

from hello_imgui.

wkjarosz avatar wkjarosz commented on June 7, 2024

Yes, that does sound like a better way to fit it in. I'll give it a try and let you know.

from hello_imgui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.