Attribute which named archive made the too deep stack error. about public_activity

[farnoy]

Try params: { archive: :archive}
(notice that the first semicolon in this expression is dropped)

[pokonski]

That's incorrect Ruby syntax. Like @farnoy said.

[cza0012]

I am sorry that it is my typo. I actually use ruby params: { archive: :archive}. I have try different name such as archive_question, but it does not work too.

[pokonski]

How does your model look? Do you have custom accessors for archive?

[cza0012]

No, I add it into a table and put it to params. It show the error. If I remove it from params, the system work fine.

[farnoy]

Do you use any gems or libraries that could possibly give you the :archive method on your model?

[pokonski]

Also try alternative method:

tracked owner: Proc.new{ |controller, model| controller.current_user }, params: { archive: Proc.new{|_, model| model.archive} }

[cza0012]

include PublicActivity::Model
attr_accessible :anonymous, :code, :content, :error, :title, :user_id, :notifications_attributes, :tag_list, :fast_answer, :archive
acts_as_taggable
validates :user_id, presence: true
#The number of questions per page
self.per_page = 10
# tracked 
tracked owner: Proc.new{ |controller, model| controller.current_user }, params: { title: :title, content: :content, code: :code, error: :error, anonymous: :anonymous, fast_answer: :fast_answer, archive: :archive}

belongs_to :user, :inverse_of => :questions
has_many :usefuls, :as => :usefulable
has_many :comments, :inverse_of => :question
has_and_belongs_to_many :feedbacks
has_one :good_answer, :inverse_of => :question
has_many :notifications, :as => :sendable
accepts_nested_attributes_for :notifications, :reject_if => lambda { |a| a[:user_id].blank? }
after_save :automatic_feedback
before_save :tag_token

I used acts_as_taggable.

[farnoy]

This one ?

[cza0012]

Yes

[pokonski]

Try the Proc method I posted above. If that doesn't work either then we will dig deeper.

[cza0012]

It works fine. Thank you for your help.

tracked owner: Proc.new{ |controller, model| controller.current_user }, params: { archive: Proc.new{|_, model| model.archive} }```

[cza0012]

In Proc.new{|_, model| model.archive}, what does the _ mean?

[pokonski]

Normally you'd write

Proc.new{|controller, model| model.archive}

In Ruby _ can be used in place of a variable you don't need.

Also thank you for reporting the issue 👍, this clearly should not happen and we will investigate and fix if possible.

[cza0012]

Thank you I am a newbie.

[cza0012]

  include PublicActivity::Model
  attr_accessible :anonymous, :code, :content, :error, :title, :user_id, :notifications_attributes, :tag_list, :fast_answer, :deleted_question
  acts_as_taggable
  validates :user_id, presence: true
  #The number of questions per page
  self.per_page = 10
  # tracked 
  # deleted_question should be archive_question
  tracked owner: Proc.new{ |controller, model| controller.current_user }, params: { title: :title, content: :content, code: :code, error: :error, anonymous: :anonymous, fast_answer: :fast_answer, deleted_question: :deleted_question}

  belongs_to :user, :inverse_of => :questions
  has_many :usefuls, :as => :usefulable
  has_many :comments, :inverse_of => :question
  has_and_belongs_to_many :feedbacks
  has_one :good_answer, :inverse_of => :question
  has_many :notifications, :as => :sendable
  accepts_nested_attributes_for :notifications, :reject_if => lambda { |a| a[:user_id].blank? }
  after_save :automatic_feedback
  # before_save :tag_tokens

  def deleted_question
    self.lock!
    self.deleted_question = true
    self.save
  end

I found that if attribute and method have a same name, it will create too deep stack error.

[pokonski]

No, you are creating the stack too deep error:

def deleted_question
    self.lock!
    self.deleted_question = true
    self.save
  end

Basically every time you are accessing deleted_question it saves itself, then tries to create an activity about it, then accesses the deleted_question which saves itself again. It's stuck in an infinite loop calling itself all the time. So you do create custom accessors, I asked about it before and you said you don't.

Also saving a model from inside a getter is a bad, bad practice, don't do it. I don't think you realize what it does. Why would you ever want to change the value while trying to access it?

[cza0012]

Thank you. I added this code, after the problem was solved at the first time.