Comments (5)
Hello.
I'm thinking about closing this issue. Just tell me if these steps are correct.
- add a method "getTotalAccess" to PersisterInterface and all the class that implements it that returns the key STAT.TOTAL
- Modify homeAction in PageController to read the total count and pass it to the view
I can later implement the live count. But let's start with this easy version
from badge-poser.
Hi that's great,
yes this could be a good way,
but PersisterInterface
is used now to Persist and only store data as RedisPersister does.
What do you think to create another interface and another service only to handle and manage statistic?
This could introduce a little bit of overhead but at least we could split the concern.
About the modification yes this is a good way,
I was thinking about a new Controller in StatsBundle that serve only the number, and use render
in /src/PUGX/BadgeBundle/Resources/views/Page/home.html.twig
...
But I'd go for your idea is simpler and maybe cleaner 💃
YEAAA
from badge-poser.
I was also thinking about create a new interface/service to read stats. So, ok for me. Hope to send my PR soon.
Ciao
from badge-poser.
👯
from badge-poser.
closed by #90
from badge-poser.
Related Issues (20)
- Upgrade to Symfony 6.4 (or maybe 7.0) HOT 1
- "Client::AUTH_HTTP_TOKEN" authentication method is deprecated HOT 2
- Improve rendering on small screens (mobile)
- Copy all badges uses the phpunit/phpunit urls HOT 4
- Shields broken after repo was moved HOT 13
- Badge shows very old download count HOT 15
- Badge shows very old stable release HOT 2
- [UX] reduce headlines and buttons in the mobile version?
- Add php version badge (and maybe other dependencies) HOT 1
- Add a way for different styled badges HOT 17
- Description can be empty HOT 1
- Removing parameters from services adding dictionaries HOT 1
- What data privacy/retention policies apply to badge requests from poser.pugx.org?
- Wrong badges in this repo
- HTTP protocol used while displaying badges in homepage
- CirceCI integration is not working
- ErrorException: Deprecated: unserialize(): Passing null to parameter #1 ($data) of type string is deprecated HOT 1
- TypeError: App\Controller\SnippetController::isValidRepositoryName(): Argument #1 ($repository) must be of t...
- Error: Call to a member function getTotal() on null
- Migrate providers in tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from badge-poser.