GithubHelp home page GithubHelp logo

Comments (5)

hpatoio avatar hpatoio commented on August 20, 2024

Hello.

I'm thinking about closing this issue. Just tell me if these steps are correct.

  • add a method "getTotalAccess" to PersisterInterface and all the class that implements it that returns the key STAT.TOTAL
  • Modify homeAction in PageController to read the total count and pass it to the view

I can later implement the live count. But let's start with this easy version

from badge-poser.

liuggio avatar liuggio commented on August 20, 2024

Hi that's great,
yes this could be a good way,

but PersisterInterface is used now to Persist and only store data as RedisPersister does.
What do you think to create another interface and another service only to handle and manage statistic?
This could introduce a little bit of overhead but at least we could split the concern.

About the modification yes this is a good way,
I was thinking about a new Controller in StatsBundle that serve only the number, and use render in /src/PUGX/BadgeBundle/Resources/views/Page/home.html.twig...
But I'd go for your idea is simpler and maybe cleaner 💃

YEAAA

from badge-poser.

hpatoio avatar hpatoio commented on August 20, 2024

I was also thinking about create a new interface/service to read stats. So, ok for me. Hope to send my PR soon.
Ciao

from badge-poser.

liuggio avatar liuggio commented on August 20, 2024

👯

from badge-poser.

liuggio avatar liuggio commented on August 20, 2024

closed by #90

from badge-poser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.