Comments (11)
wait, we still want to have page.setOfflineMode
implemented :)
from puppeteer.
If you don't want to run as root but still want to have some level of automated traffic shaping (even if low fidelity). Then what you'd want to do is setup a proxy for those tests. Do it where any tests that need throttling use an instance that is talking to your proxy that will handle the network manipulation. You'd pass the proxy in when launching an instance just like you would from the command line as an arg
option.
let instance = puppeteer.launch({
args: [
'--proxy-server=127.0.0.1:9876', // Or whatever the address is
]
});
This allows you to use other external tools to manage the network shaping. Such as Charles Proxy on Mac OS. Finding a good cross-platform solution for testing is difficult though, as Windows in particular is dramatically different to talk to.
from puppeteer.
A proxy should. Since that is an entire external man-in-the-middle between the program and the network interface.
from puppeteer.
@paulirish @ebidel how do you guys feel about the page.setOfflineMode
? This seems to be trivial to implement but really useful. We can add a page.setNetworkConditions(condition)
method later if there's a need to, and keep the setOfflineMode
as an alias for setNetworkConditions('offline')
.
from puppeteer.
This is blocked on Chrome Headless network emulation support: https://bugs.chromium.org/p/chromium/issues/detail?id=728451
from puppeteer.
As discussed with @pavelfeldman, we should not do anything other then setOfflineMode
- we're pretty bad at network shaping. There's a specific tooling which does this much better and on a much lower level.
from puppeteer.
@aslushnikov do you mind elaborating on this? I would love to be able to do network emulation to test scenarios in my app.
Alternatively, a docker container image that runs something that does do network condition throttling would be great.
For example I need to test a scenario where 2 clients are communicating with a server.
from puppeteer.
@benjamingr The devtools throttling has some issues: Network Throttling & Chrome - status
Alternatively, a docker container image that runs something that does do network condition throttling would be great.
I've discussed this with Pat Meenan of webpagetest and he indicates docker isn't a reliable solution for network shaping as you cannot modify the network interface within the container; the network interface is bridged with the host. This was unfortunate news to me as well. :)
Using dummynet to change the entire system's network shaping (and requiring sudo) are just required on the host machine for high quality throttling. Not ideal but that's what it is.
from puppeteer.
Thanks @Garbee that's very helpful.
@paulirish that makes sense. I think we'll go ahead with a proxy server solution.
from puppeteer.
@Garbee would that also intercept DataChannels traffic?
from puppeteer.
Thanks, I think that this can be closed now.
from puppeteer.
Related Issues (20)
- Chrome Canary test results HOT 45
- [Bug]: HOT 1
- [Bug]: HOT 7
- [Feature]: Add ability to exclude web sockets from WaitForNetworkIdle HOT 1
- Error: Passed function cannot be serialized! HOT 5
- [Bug]: Navigation failed because browser has disconnected! HOT 2
- Test "[click.spec] Page.click should click the button with fixed position inside an iframe" is flaky
- [Bug]: Failed to launch browser process. HOT 2
- Failed to launch the browser process! on WSL but working on local HOT 2
- HTTPRequest is checking for chrome-only error message "Invalid header" HOT 2
- [Typo] Docs have a misspelling in arhicture HOT 1
- [Bug]: Pages within the electron project cannot be connected HOT 8
- [Feature]: when I want to generate a pdf with 2 per sheet each, I don't find the corresponding api in "page.pdf (options?: PDFOptions)".
- [Feature]: Track the originator of http request HOT 1
- [Bug]: Error: Attempted to use detached Frame 'xxx...xxx' after waking up from standby HOT 14
- [Bug]: Puppeteer Cache Folder Not Reinstalling in ~/.cache After Update and Reinstallation HOT 2
- [Bug]: Protocol error (DOMDebugger.getEventListeners): Invalid parameters Failed to deserialize params.objectId HOT 2
- Inject js into chrome extension HOT 3
- [Bug]: An Error Occurred on the Page Due to Code Execution HOT 7
- [Bug]: The popup listener can't catch popups. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppeteer.