pe_step1 remediation fails when incrementing "idx" about puppetlabs-cve20113872

[jeffmccune]

This is an issue with how bash treats set -e on different plaforms. Incrementing from 0 to 1 returns an exit code of 1 on all platforms but set -e on CentOS 5.5 appears to ignore this and continue with the script.

The test Script

#! /bin/bash
set -x
set -e
set -u
idx=0
((idx++))
echo "rval: $?"
echo "idx: $idx"

On CentOS 5.5

root@pe-centos5:/vagrant/bin# ./test 
+ set -e
+ set -u
+ idx=0
+ (( idx++ ))
+ echo 'rval: 1'
rval: 1
+ echo 'idx: 1'
idx: 1

On Lucid

root@pe-ubuntu-lucid:/vagrant/bin# ./test ; echo $?
+ set -e
+ set -u
+ idx=0
+ (( idx++ ))
1