subscribing to multiple private channels simultaniously fails about libpusher

[lukeredpath]

Interesting. I'll take a look at this tomorrow (just heading off to bed) and see if I can reproduce using my test harness. There are also some other bugs around channels I need to look at too (see #25).

On a side-note, it's cool to hear you're using this for Gaug.es - I've been meaning to try it out for ages.

[lukeredpath]

Also, out of interest, do you do any further customisation of the authorisation request (e.g. inject an auth token header, set up basic auth) in the pusher:willAuthorizeChannelWithRequest: delegate method?

[bkeepers]

@lukeredpath thanks for following up so quickly.

We are adding the user's token to the request:

- (void)pusher:(PTPusher *)pusher willAuthorizeChannelWithRequest:(NSMutableURLRequest *)request {
  [request setValue:User.token forHTTPHeaderField:@"X-Gauges-Token"];
}

[lukeredpath]

@bkeepers I was also wondering if you've tried the use-socket-rocket backend branch. It's still being tested but I've ripped out the web socket backend for one that's more up-to-date, conforms to spec and is being actively maintained (it's developed by the guys over at @square).

[bkeepers]

I Haven't. We can give that a try.

On Feb 28, 2012, at 4:28 PM, Luke [email protected] wrote:

@bkeepers I was also wondering if you've tried the use-socket-rocket backend branch. It's still being tested but I've ripped out the web socket backend for one that's more up-to-date, conforms to spec and is being actively maintained (it's developed by the guys over at @square).

---

Reply to this email directly or view it on GitHub:
#26 (comment)

[lukeredpath]

@bkeepers some positive news is that I've been able to reproduce your issue (see the functional spec I've added in the above commit). If I can't get to the bottom of this tonight, I will do my best to fix this tomorrow.

[lukeredpath]

@bkeepers good news - I found the source of the bug. See the commit for more details. Thanks for reporting this issue, that could have lied undiscovered for a while.

I intend to get the use-socketrocket-branch merged into master ASAP and release a new version, but in the meantime please use the use-socketrocket-branch.

Me, on finding the bug:

[bkeepers]

Awesome, thanks! We'll give it a try tomorrow. If all goes well, we'll ship the next version of the Gaug.es iOS app using libPusher. :)

Thanks for your great work!

[bkeepers]

I never followed up. That worked beautifully. The next version of the Gauges iOS app is submitted and waiting for approval. Thanks for sharing libPusher!

[lukeredpath]

Thanks for the follow up, great news. You are welcome.