Comments (3)
Hi,
I thought about including built files in the repo and I heard we were doing it some time ago. There are a few issues with this approach:
- it's possible to forget to commit changed files,
- files have to be in sync with those hosted on our CDN,
- diffs grow considerably and browsing the repository becomes more difficult.
Personally, I don't like leaving room for human errors and I'm afraid this would cause problems eventually.
Why is it difficult to build the library for you? Maybe there's another solution to this problem. Potentially, you can fork pusher-js and store dist in it. Merging new changes should be straightforward this way.
from pusher-js.
Hi,
- True, solution: automate it if necessary using Travis.
- Solution: Travis could also help here (push to CDN after tests pass), there's currently room for human error ( someone forgets to upload the latest version, same argument for 1. )
- From my experience this hasn't become an issue on projects with far more activity like Lo-Dash, Backbone, Underscore, etc. Browsing on Github should remain the same, cloning from scratch (non shallow) would be affected indeed but on a minimal level since we're not talking about binary files, pulls would suffer even less impact.
I've forked and had someone else commit the dist.
The current build seems very convoluted, maybe reduce the toolchain and dependencies? I'm having issues with gems, bundler on my machine, perhaps try asking non-ruby devs to go through the build process and identify pain points.
from pusher-js.
I had to reconsider this issue for Bower integration, so from version 2.1.2 the dist
directory will contain pre-built scripts and Flash files. You can use the v2.1.2
tag for now as it's the only one with distributables.
from pusher-js.
Related Issues (20)
- Please don't deprecate React Native in `pusher-js`
- Pointer not working to decline cookies HOT 2
- WebSocket Compression HOT 11
- Pusher User Authentication Endpoint and params not being overridden HOT 3
- Gateway 504 error and how to handle it gracefully HOT 2
- { "type": "PusherError", "data": { "code": null, "message": "Missing parameter: data.user" } } HOT 3
- BUG - Error: Connection closed. (active status - Code With Antonio) HOT 16
- YukTam HOT 1
- Bug: Webhook not triggered after subscribe and unsubscribe event HOT 1
- 401 (Unauthorized) when subscribing to private-channel (Vue/Laravel)
- Incorrect TypeScript types for class with `moduleResolution: "nodeNext"` HOT 2
- Error `Unable to resolve module @react-native-community/netinfo` HOT 1
- TypeError: Object(...) is not a function at Object.randomInt HOT 10
- PWA HOT 1
- Constant connection state changes when using other than ws transports HOT 3
- Not actuall stats HOT 6
- Pusher-JS doesnt play well with NextJS 14 : Uncaught SyntaxError: Unexpected token ':' HOT 2
- Providing Custom Handler, Internal Endpoint Still Calls
- Pusher client is not binding correctly on presence channels but on public ones yes HOT 2
- Pusher websocket URL triggering events and sending data HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pusher-js.