GithubHelp home page GithubHelp logo

Comments (7)

pl avatar pl commented on July 21, 2024

I agree, the current solution is far from perfect. In your case, it might be better to whitelist transports than to blacklist them. We might be introducing some new transports and if you just blacklist SockJS and Flash, you might end up with some fallbacks enabled anyway, which is not what you'd really want. Whitelisting WebSockets would work fine in your case and you wouldn't change anything when updating pusher-js.

from pusher-js.

sandstrom avatar sandstrom commented on July 21, 2024

Sounds good! How do I go about whitelisting them? I cannot find anything in the source (searching for white finds nothing).

from pusher-js.

pl avatar pl commented on July 21, 2024

It's not supported, I was thinking whether to replace this issue with implementing a transport whitelist.

from pusher-js.

pl avatar pl commented on July 21, 2024

Released today in 2.1.4 (enabledTransports and disabledTransports options). Closing, thanks for the issue.

from pusher-js.

sandstrom avatar sandstrom commented on July 21, 2024

Awesome! ⛵

(perhaps you should deprecated the disableFlash option, for clarity)

from pusher-js.

pl avatar pl commented on July 21, 2024

It will be deprecated in 2.2 and removed in 3.0.

from pusher-js.

sandstrom avatar sandstrom commented on July 21, 2024

Nice! Just tried 2.1.4, works great!

from pusher-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.