"NetworkCallback was already unregistered" if re-using Observable about reactivenetwork

[0xGuybrush]

Just to note, if anyone else comes across this, that I now think the correct way of reusing this in RxJava is to turn it into a ConnectableObservable to allow multiple observables to chain to it and will only dispose when the final downstream Observable disconnects.

I've used .share() here to handle this and seems to be working fine to turn it into a "hot" observable. Closing ticket, as it's due to my knowledge gap rather than an issue here 🙂

[pwittchen]

Hi,

Thanks for reporting issue. I suppose this problem may be related to the fact that there is more than one Disposable per from the ReactiveNetwork single Activity and the same objects could reused. Due to this fact, when NetworkCallback is unregistered once, then another one cannot be unregistered because of the same object. I'm not sure about that, but that's my guess.

Regards,
Piotr

[0xGuybrush]

Hi Piotr,

thanks for your reply & getting back so quickly.

I have multiple pieces of functionality that depend on network state in some of my activities, so thought the cleanest way was to reuse, but I'll see if I can refactor it though to use a single disposable instead.

Best
Dave

[pwittchen]

Great! I'm glad you solved this issue. :)