GithubHelp home page GithubHelp logo

PNL - Test2 about causal-learn HOT 3 OPEN

diogocruz17 avatar diogocruz17 commented on June 24, 2024
PNL - Test2

from causal-learn.

Comments (3)

ErdunGAO avatar ErdunGAO commented on June 24, 2024 1

That seems to be the problem, there is a small difference in the p_value_forward_2 to the simulated one. image Third test passes and the real case also has a small deviation. image

Thanks for the reporting results! We have encountered a similar issue in some other implementations before, where updates to the underlying computation library caused the test examples to fail. Thank you for your information; we will update these assert statements ASAP.

from causal-learn.

ErdunGAO avatar ErdunGAO commented on June 24, 2024

Hello. I was applying the PNL algorithm to some data and was getting unexpected results. Upon running the tests, I get an error in test_pnl_simulation_2, for the p_value_forward_2 value. Is there a known problem regarding this? Screenshot from 2023-11-22 15-41-45 Thank you

Thank you for bringing up this issue. I've run the second test myself, and it successfully passed.

image

I'm considering that the error might be raised from the update in some fundamental packages, such as scipSklearnlearn. Could you verify the precise values of p_value_forward_2 and p_value_backward_2? We're considering updating that asserting exact values to defining intervals, which we think will provide better resilience against potential minor issues arising from future updates to these core packages.

from causal-learn.

diogocruz17 avatar diogocruz17 commented on June 24, 2024

That seems to be the problem, there is a small difference in the p_value_forward_2 to the simulated one.
image
Third test passes and the real case also has a small deviation.
image

from causal-learn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.