GithubHelp home page GithubHelp logo

Comments (5)

moprescu avatar moprescu commented on August 25, 2024

How does that influence the effect function? I.e. would the user still be able to call effect(x) and effect(x, 0, 1)?

from econml.

vasilismsr avatar vasilismsr commented on August 25, 2024

it will have to be effect(x, T0=0, T1=1)

from econml.

kbattocchi avatar kbattocchi commented on August 25, 2024

@moprescu, that is a good question.

The simplest approach would be to apply the same rule to effect itself, so that you could call effect(x) and effect(x, T0=0, T1=1) but not effect(x, 0, 1), although this would be a breaking change which otherwise seems unnecessary (since there's no ambiguity here).

Unfortunately, if we want the bootstrap wrapper to remain generic, then it's hard to see how to fix effect_interval without changing effect...

from econml.

kbattocchi avatar kbattocchi commented on August 25, 2024

@moprescu The changes in #75 will make these arguments keyword-only for effect_interval while leaving effect untouched by explicitly creating an effect_interval method on BaseCateEstimator.

from econml.

vasilismsr avatar vasilismsr commented on August 25, 2024

#75 addresses this

from econml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.