Wrong address from PrivateKeyTestnet about bitcash

Hi Anastasia!

I'm sorry for the wait. Have been out for a few days. I'll take a look into this and get back to you shortly. I do have some test cases with testnet, but my use has all been mainnet, so the odds of a bug with testnet are fairly high.

-Teran

Okay, turns out this isn't a bitcash bug afterall. ccoin.cash is using the old Bitcoin address format and hasn't updated to cashaddr. If you want to use bitcash with ccoin, you'll need to convert the cashaddr to the legacy address.

One site you can do this with is: https://cashaddr.bitcoincash.org

If you want to keep this within Python, you can do so with cashaddress: https://github.com/oskyk/cashaddress

cashaddress is already used inside this repository. You can send to legacy addresses, but the .address property will always return the cashaddr format.

I hope this helps! Let me know if you have any questions.

Oh, about raw transactions, just use .create_transaction() and it will give you something that you can broadcast, just the hex output.

https://github.com/sporestack/bitcash/blob/master/bitcash/wallet.py#L208

[anastasiia-bilova]

Teran, thank you so much for your reply!

You helped me a lot, with new converted BCH address everything works!

And thank you for your cool library!

[AustEcon]

anastasia-bilova - I found a great library for converting between BCH and legacy addresses natively in python - https://github.com/oskyk/cashaddress - super handy little one to have in your tool belt :)

You're welcome! Glad I could help.

Though most of the credit goes to @ofek, he wrote the bit library for Bitcoin which I ported this from. He did 99% of the legwork.

[AustEcon]

I would also like to thank you for this library. Absolutely amazing. You have made a huge difference to the BCH ecosystem with this, regardless of who did the original core work. Still takes effort to connect all the ports, add extra features, taylor it to BCH and make it work right out of the box.

Thank you! I really appreciate that. I needed it myself and I'm glad you've been able to find it useful as well.

Will close this out for now.