GithubHelp home page GithubHelp logo

Comments (4)

Chedi avatar Chedi commented on June 3, 2024

a little addendum, the tests will not work with a pytest version < 6.1.0 as the type annotation has only been added on that version

pytest-dev/pytest@acc9310#diff-bad7b9b2d1db5b8a39a3afbf2e9d783f341a11b50b8081b91f01f66efb8891c7

the errors I get on version 6.0.2 (but not with 6.1.0)

========= test session starts =========
platform linux -- Python 3.9.0, pytest-6.0.2, py-1.9.0, pluggy-0.13.1
rootdir: /mnt/56298eef-80c6-43f5-8aee-172b1d73d266/Projects/Fedora/python-subprocess-tee/subprocess-tee-0.1.5-test, configfile: setup.cfg
collected 2 items / 2 errors

========= ERRORS =========
_________ ERROR collecting lib/subprocess_tee/test/test_unit.py _________
lib/subprocess_tee/test/test_unit.py:48: in
def test_run_echo(capsys: CaptureFixture[str]) -> None:
E TypeError: 'type' object is not subscriptable
_________ ERROR collecting lib/subprocess_tee/test/test_unit.py _________
lib/subprocess_tee/test/test_unit.py:48: in
def test_run_echo(capsys: CaptureFixture[str]) -> None:
E TypeError: 'type' object is not subscriptable
========= short test summary info =========
ERROR lib/subprocess_tee/test/test_unit.py - TypeError: 'type' object is not subscriptable
ERROR lib/subprocess_tee/test/test_unit.py - TypeError: 'type' object is not subscriptable
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
========= 2 errors in 0.18s =========

from subprocess-tee.

ssbarnea avatar ssbarnea commented on June 3, 2024

Sure. The min test requirements are not well tested as pip always installs current versions. Feel free to raise a PR to bump the minimal pytest version needed for running tests.

For stuff like this we can even skip creating a bug.

from subprocess-tee.

Chedi avatar Chedi commented on June 3, 2024

added pr #20

from subprocess-tee.

ssbarnea avatar ssbarnea commented on June 3, 2024

Thanks.

from subprocess-tee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.