Expose a DateTime type? about httpdate

[pyfisch]

Hi, I want to hide DateTime as an implementation detail and only use the standard SystemTime. Avoiding the allocated string would be good. I could either provide a function like this:

pub fn format_http_date(f: &mut fmt::Formatter, d: SystemTime) -> fmt::Result {
    DateTime::from(d).fmt(f)
}

It avoids the intermediate string but it can only be called if you already have a formatter. The alternative would be a type pub struct HttpDate (SystemTime} and implement FromStr and Display for it. Do you know if the smaller size of DateTime actually makes a difference?

[tailhook]

Well, the tokio's structures are generally quite large. And sure, 16 bytes vs 8 bytes of timestamp does not matter here.

Still I'm not sure why you want a yet another wrapper. There is no need to expose any methods or internal structure of DateTime except FromStr, Display, From, Into and perhaps a PartialOrd. So both options will look the same from the point of view of a user.

[pyfisch]

There is no need to expose any methods or internal structure of DateTime except FromStr, Display, From, Into and perhaps a PartialOrd. So both options will look the same from the point of view of a user.

Ah good idea. So parse_http_date would return an opaque DateTime and can be converted to a SystemTime if necessary. It can also be formatted with Display. Maybe DateTime is too generic would you agree to name it HttpTime?

[tailhook]

Yes HttpTime sounds good.

[pyfisch]

While editing the code I noticed that the crate is called httpdate but the type would be named HttpTime. Either I need to rename the crate and yank the old version or I should call it HttpDate.

[tailhook]

For that matter, I think HttpDate is equally meaningful as HttpTime :)

[pyfisch]

Sorry for the delay, can you please have a look at the publicdate branch? I will release it after your review.

[tailhook]

Looks good. Thanks!

[pyfisch]

Published as v0.3.0