GithubHelp home page GithubHelp logo

Comments (2)

Zsailer avatar Zsailer commented on August 20, 2024 2

I agree with @ericmjl here.

pyjanitor aims to be a general purpose library that extends the Pandas API. Users should be able to add pyjanitor to their current workflow without breaking their existing code.

If pyjanitor starts patching pandas functions/methods, it could quickly cause trouble for users and prevent them from using pyjanitor.

Also, I don't think you need a sophisticated tool like pyjanitor to fix your problems. Because read_csv, read_excel are just functions, you could create a small module that enforces the signature you want:

import pandas as pd
from functools import wraps

@wraps(pd.read_excel)
def read_excel(parameters_that_you_want):
    # Only include the parameters you want in the function signature.
    return pd.read_excel(parameters_that_you_want)

Perhaps this would solve your problem until Pandas addresses the issue?

from pyjanitor.

ericmjl avatar ericmjl commented on August 20, 2024

Is it possible to "fix" pandas methods using pyjanitor? ... If janitor accept the PR to override the default behavior of read methods, then it will be great.

@shantanuo I'd be inclined to disagree with doing that. The purpose behind pyjanitor is to provide the convenience APIs that pandas did not provide. If there's a bug that's inside pandas, then that should be raised with the pandas devs, as you did already.

from pyjanitor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.