Comments (12)
That said, since pyjanitor is supposed to be the Python implementation of janitor, it would go against the spirit of the package to provide an alternative verb.
To that, in general, I'd personally say "meh". I think we have a good thing going with carefully choosing names for functions, and I'm not sure the relative weight of keeping people migrating from R to Python comfortable vs. sticking to the vision of the project leans towards the former.
That being said, in this particular case, since there is a whole family of adorn_
functions instead of just one, it might not be a big deal to keep that term... In the docs, we can explain the concept of what this class of functions is trying to accomplish - "make it look good" is a pretty simple concept that you just have to learn once and then you know what that entire group is trying to accomplish at a glance.
from pyjanitor.
In the docs, we can explain the concept of what this class of functions is trying to accomplish
Yes, yes! Docs. I really need to improve the docs, big thanks to both of you for helping so much with the documentation!
from pyjanitor.
And to add to this thread: https://sfirke.github.io/janitor/news/index.html
Janitor 1.2.0 was released recently! 🎉 That means more functionality that we can try targeting to port over.
from pyjanitor.
Thanks for taking the effort to document this, @szuckerman!
One little question: I had a bit of trouble with the "adorn" semantics (implementation is fine with me) - is there a more accessible English verb for non-AABCs (Americans/Aussies/Brits/Canadians)? Even as a Canadian whose first language is English, I didn't think the "adorn" verb was that informative. Thinking from an ESL perspective, that verb would be considered quite foreign.
That said, since pyjanitor is supposed to be the Python implementation of janitor, it would go against the spirit of the package to provide an alternative verb. I guess issues with the semantics would belong on the original R package issue tracker instead.
from pyjanitor.
Perhaps “stylize” or “add_style”?
Or maybe “add_formatting”?
from pyjanitor.
convert_to_NA.R
has been deprecated in favor of dplyr::na_if()
and use_first_valid_of.R
has been deprecated in favor of dplyr::coalesce()
.
We already have a coalesce
method, but do we have something that is similar to the dplyr::na_if()
function? fill_empty
?
from pyjanitor.
fill_empty
, I think, does something different from the na_if()
?
from pyjanitor.
I finally got some time to look at it: na_if()
puts a null
value in a column if a cell value is equal to some number.
from pyjanitor.
I don't know if the adorn_
family naming has been settled or not, but I had some ideas depending on what you all think:
top_with_*
In the sense of garnishing (this word seemed to connected to adorn) a dish or drink with final touches (which may be too long,final_touch_*
coat_with_*
in the sense of polishing a floortweak_*
since these are usually little, but important, changes (probably my favorite)
from pyjanitor.
Those are great ideas, @robertmitchellv! Given enough time away from the issue, and the recent improvements to the docs, I think I have less issue with the name adorn_
.Back when the issue was started, we didn’t have a taxonomy/ontology for the functions on the docs page, and so I was worried about the adorn functions’ purpose being unclear. But now that it was contributed (I think at PyCon), and because the adorn
functions form a family of functions on their own for “stylizing” a dataframe, I think they should totally come in!
Are you open to trying your hand at one of them via a PR?
from pyjanitor.
Yeah, I think I can try!
I've been reviewing the source code a lot to get more familiar with how things are done in pyjanitor
and wrote my first copy of dplyr::count()
so hopefully I can figure out the best way to make one of the simpler adorn_*
functions happen--I'm hoping for a good amount of back and forth the get it to the place where it's polished. Coming back to Python after maybe 5 years 😬
from pyjanitor.
Welcome back!
To get started, the docs are the best place to go. They're intended to be quite beginner-friendly, so if you run into issues getting set up, don't hesitate to sneak in a few modifications to the docs too 😄! And feel free to ping around on the issue tracker if there's any issues you run into!
from pyjanitor.
Related Issues (20)
- [INFRA] Switch over to pyproject.toml
- Support efficient json extraction within a pandas column HOT 1
- [ENH] implement full numba version of a single conditional_join
- deprecation warning for pivot_longer HOT 1
- Return only matching indices for `conditional_join`
- [ENH] cython a subset of _range_join_indices and equi join HOT 4
- extend `col` powers for index selection HOT 1
- dtype conversion on index
- `conditional_join` fails on mac for `equi-join` and numba HOT 1
- Outdated version in conda forge HOT 1
- extend `row_to_names` to support multiindex
- `sheet_name` not required in jn.xlsx_table
- Problems with equalities in contional_join HOT 18
- Make clean_names() compatible with polars and geopandas dataframes HOT 6
- implement similar functions for polars HOT 4
- perf slower when `sort_by_appearance` is True for `pivot_longer`
- Question about "tabyl()" in pyjanitor HOT 1
- sub-repo for performance optimisations in a lower level language
- add `strip_whitespace` to `clean_names` function
- importing janitor fails HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyjanitor.