GithubHelp home page GithubHelp logo

Writing in nodefile about pylada-light HOT 5 CLOSED

pylada avatar pylada commented on June 15, 2024
Writing in nodefile

from pylada-light.

Comments (5)

ftherrien avatar ftherrien commented on June 15, 2024

I suggest:
print "config/mpi: machine_dep_call_mod: nodefile contents: \"%s\"" % fin.read()
to be consistant with the previous behavior, or:
logger.debug("config/mpi: machine_dep_call_mod: nodefile contents: \"%s\"" % fin.read())
I can commit the changes, I just don't know which one is preferable.

from pylada-light.

mdavezac avatar mdavezac commented on June 15, 2024

Indeed. I think writing directly to the debug logger is best. Something like:

logger.debug("config/mpi: machine_dep_call_mod: nodefile: \"%s\"" % nfile)
logger.debug("config/mpi: machine_dep_call_mod: nodefile contents: \"%s\"" % open(nfile).read())

This probably happened when we moved from print to a real logger. If you can make those changes, that would be much appretiated!

from pylada-light.

mdavezac avatar mdavezac commented on June 15, 2024

Thanks! It would have been more kosher to do this via a pull request though :)
I think the error on travis is unrelated. Probably something about them using too old a version of ubuntu...

from pylada-light.

ftherrien avatar ftherrien commented on June 15, 2024

Yes you are right sorry! I did not realize I can do a pull-request even if I can pull directly. I will know for next time!
I am not sure what the problem is with travis. What is the error output?

from pylada-light.

mdavezac avatar mdavezac commented on June 15, 2024

No worries. To do a PR in the same repo, you just need to make changes in a separate branch.
I'll take care of the Travis error (see #27). It's just an infrastructure issue.
Thanks again!

from pylada-light.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.