Comments (7)
Assigned to this as well. I would suggest closing the two you're assigned to before taking on any more issue tickets
from pymc-examples.
@almostmeenal Yes, I think updating the NBs to use best current practices is important, like arviz and coords
.
from pymc-examples.
@OriolAbril can I take this up
from pymc-examples.
ran into some error- arviz-devs/arviz#1117 (comment) , also random but would it be a good idea to possibly create a similar example notebook with something like ucl or something, with recent data and current best practices, I saw that this notebook didnt even import arviz. can something be done to ensure examples get updated accordingly each time a new PR is merged which revamps/removes/modifies/adds a new feature or utility to ensure they stay updated. I mean, as contributors yeah we can look up errors and everything but for users who want to learn from examples repo, running into errors there, it is kind of hard to fix.
from pymc-examples.
@OriolAbril hi so I'm thinking a lot of things and I'm slightly lost wrt what exactly am i supposed to do, so I'll start a pull request while I'm working on it so you can maybe help me out a bit, from what I think, I guess I'm supposed to change the part after building the model and use arviz inference data format for data and arviz plots instead of the ones used. and for building the model take the part from rugby.ipynb in arviz_example_data
from pymc-examples.
Sending a PR sounds great! I have been adding more and more guidance and content but I can't go as fast as I'd like. For now you'll see I have already added a contributing guide that is specific to pymc-examples and when you submit the PR, you'll see I have also added a pull request template.
I guess I'm supposed to change the part after building the model and use arviz inference data format for data and arviz plots instead of the ones used
yes, these changes would "move" the notebook from "To Do" to "ArviZ" column.
and for building the model take the part from rugby.ipynb in arviz_example_data
and these changes would move from "To Do" to "General updates", if all changes in here and the point above are done, then the notebook would end up placed in "Best Practices". I hope the explanation on the contributing guide is also clear on that (if not please let me know how to improve it). Note however that the model in arviz_example_data is an starting point, there are still some more updates to do like using coords
and dims
when building the model.
from pymc-examples.
thankyou!! i read the guide and um here's the PR, #62
I changed a few plots to arviz wherever I could, for some I'm still a lil confused. The inference data is arviz style and the plots use coords, and replaced old functions like pm.hpd with az.hdi. I was wondering how to use az.quantile since there's a line using "np.quantile" and I figured we could try that. So yeah, its definitely a WIP but moving towards good practices.
from pymc-examples.
Related Issues (20)
- New distributions with `CustomDist` HOT 2
- Not rendering the bibtex references at the bottom of notebooks HOT 2
- Proposal: Restructure Core Notebooks section
- Fix broken references HOT 7
- Change category items for beginner, intermediate, advanced from birds to text HOT 2
- Propose example notebook on Bayesian Power Analysis
- Notebook Profiling needs to update to v5
- Slight Mis-Interpretation of Discrete Choice Theory HOT 2
- Broken link in MLDA example notebook HOT 1
- Broken link in MLDA intro page HOT 1
- Propensity Score Non-Parametric Models HOT 1
- Should you buy a house battery? HOT 2
- wrapping jax example code cell 22 returns error HOT 14
- Notebook Proposal : Time Series Modeling with HSGP: Baby Births Example HOT 2
- Do operator example still mentions PyMC-Experimental HOT 4
- pre-commit-ci fails HOT 6
- Divergences in Bayesian Non-parametric Causal Inference PyMC 5.10+
- Errors in "Introduction to Variational Inference with PyMC" notebook HOT 1
- Proposal: Add HSGP reference and examples
- Bug copying URL on iPhone HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pymc-examples.