GithubHelp home page GithubHelp logo

Comments (3)

ricardoV94 avatar ricardoV94 commented on May 28, 2024

I also can't figure out how to make it work in Numba mode, for some reason it doesn't apply then

from pytensor.

ricardoV94 avatar ricardoV94 commented on May 28, 2024

Some progress, it seems that when in NUMBA mode (and I assume JAX as well), the inner fgraph of scan is not optimized according to the Scan mode. In the default backend the optimization is triggered when accessing the dynamic property node.fn, which seems to usually be done first in make_thunk. I imagine this path is not triggered by the JIT linkers.

If I access the property manually, the correct graph is obtained:

import aesara
aesara.config.mode = "NUMBA"
import aesara.tensor as at
from aesara.compile.builders import OpFromGraph

x = at.scalar("x")
out = at.log(x)
op = OpFromGraph([x], [out], inline=True)

xs = at.vector("xs")
seq, _ = aesara.scan(
    fn=lambda x: op(x),
    sequences=[xs],
)

seq.owner.op.fn  # Trigger inner fgraph optimization manually!!!

# aesara.config.optimizer_verbose = True
f = aesara.function([xs], seq)
aesara.dprint(f)

from pytensor.

ricardoV94 avatar ricardoV94 commented on May 28, 2024

#28 solves this for the NUMBA backend, but not JAX. I did not try to change it since Scan is completely broken for JAX

from pytensor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.