Comments (5)
Ok, I will look into this soon. We can start with a very long hard limit and reduce it to taste.
from pytensor.
I think that the ignore was added to ignore long lines in docstrings. The auto-formatter will fix the code part that gets long lines, but doesn't deal with long strings or multi line strings like docstrings. Sometimes, it's good for docstrings to be long lines (specially when you add tables or fancy markdown things in the middle), so it's ok to have the ignore in those cases
from pytensor.
We can add but perhaps not 88. What's the norm these days 120?
from pytensor.
I personally use 88 and almost all projects I know also use 88. My main motivation is that diffs with long lines are hard to read, especially on a laptop screen.
If it doesn't bother you then probably it's not a problem. The problem is only when you want a limit but it's not enforced.
from pytensor.
We can have a limit I am not against it. I thought we had one already.
Just find 88 very restrictive
from pytensor.
Related Issues (20)
- ENH: Supporting complex numbers
- BUG: `tensordot` is broken HOT 7
- Deprecate `pytensor.tensor.math._tensordot_as_dot` and the methods that use it
- Implement Gradient for `CholeskySolve`
- DOC: Change docstring for math functions HOT 1
- Shared and Constants are not instances of respective Variables HOT 1
- Build wheels on Windows CI is broken HOT 1
- Numba `test_vector_taps_benchmark` test started failing with 0.59 HOT 1
- BUG: gammainc C code does not have a special case for np.inf
- Offer `pytensor.tensor` user-facing functionality at the `pytensor` root level HOT 12
- Simplify dots with 1
- Define database for symbolic simplification HOT 3
- Bug: `linalg.kron` is not correct for matrices of `ndims > 2` HOT 10
- Add support for multiple output functions to `gradient.verify_grad` HOT 1
- DOC: Documentation for pymc.math.concatenate refers to `join` which is not documented.
- Vectorization of RandomVariables failing
- Missing JAX implementation of Eigvalsh HOT 6
- BUG: Possible OpFromGraph Related Issue for Choosing Samplers in MarginalModel HOT 9
- `local_sum_make_vector` rewrite can introduce forbidden float64 operations at the graph level HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pytensor.