GithubHelp home page GithubHelp logo

Comments (5)

maresb avatar maresb commented on June 24, 2024 1

Ok, I will look into this soon. We can start with a very long hard limit and reduce it to taste.

from pytensor.

lucianopaz avatar lucianopaz commented on June 24, 2024 1

I think that the ignore was added to ignore long lines in docstrings. The auto-formatter will fix the code part that gets long lines, but doesn't deal with long strings or multi line strings like docstrings. Sometimes, it's good for docstrings to be long lines (specially when you add tables or fancy markdown things in the middle), so it's ok to have the ignore in those cases

from pytensor.

ricardoV94 avatar ricardoV94 commented on June 24, 2024

We can add but perhaps not 88. What's the norm these days 120?

from pytensor.

maresb avatar maresb commented on June 24, 2024

I personally use 88 and almost all projects I know also use 88. My main motivation is that diffs with long lines are hard to read, especially on a laptop screen.

If it doesn't bother you then probably it's not a problem. The problem is only when you want a limit but it's not enforced.

from pytensor.

ricardoV94 avatar ricardoV94 commented on June 24, 2024

We can have a limit I am not against it. I thought we had one already.

Just find 88 very restrictive

from pytensor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.