GithubHelp home page GithubHelp logo

Comments (7)

maresb avatar maresb commented on August 24, 2024

Based on #802 and #803 it seems like I hit a one-off GitHub glitch with the truncation. Still fairly unsettling.

from pytensor.

ricardoV94 avatar ricardoV94 commented on August 24, 2024

pre-commit-ci is really annoying. Dependabot adds the label automatically.

from pytensor.

maresb avatar maresb commented on August 24, 2024

In a lot of instances it's really convenient, but ya, for PyMC stuff we've had a lot of weird issues with it. Do you think we should switch back to GHA?

from pytensor.

ricardoV94 avatar ricardoV94 commented on August 24, 2024

In a lot of instances it's really convenient, but ya, for PyMC stuff we've had a lot of weird issues with it. Do you think we should switch back to GHA?

I don't remember, what does pre-commit do better? Speed?

from pytensor.

maresb avatar maresb commented on August 24, 2024

It's tough to remember exactly, but off the top of my head...

Speed, yes, which does sometimes come in handy when making a PR and you get quicker feedback when something's off.

It's the more managed option, so no need to maintain a GHA workflow. For most projects it just works.

I'm inclined to just keep it as-is, but in case you do get frustrated then switching back to GHA is viable.

from pytensor.

ricardoV94 avatar ricardoV94 commented on August 24, 2024

I'm okay with it. My message above was a bit dramatic :)

from pytensor.

maresb avatar maresb commented on August 24, 2024

Decided to keep things as-is.

from pytensor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.