Comments (16)
But the only issue we're having is when you AutoPP and Manual PP the same file at the same time.
Maybe add a queue directory in the PP directory and don't allow anything to PP that "automatically", so only the thing that moved it there can handle it. Kind of like a "protected zone".
from medusa.
@OmgImAlexis I wouldnt say just dont allow the file itself becouse imagine
Top folder is Downloads you have Show1.xyz and Show2.xyz there and Folder/Show3.xyz
auto PP is PPing Show1.xyz dont allow any other PP thread to pp it beeing manual PP , or a third party via api, since thats what causes the issues.
IMO
from medusa.
Sorry @duramato i didn't understand a single word of that comment.
@OmgImAlexis, can't say I understand your comment. But my gut feeling tells me to mess as little with the filesystem as possible. So i'd prefer to not use all kinds of staging directories. And keep it as simple as possible.
from medusa.
Maybe it's a good idea to create a list of requirements which PP should be compliant to? So what do we expect from PP?
from medusa.
@p0psicles
I would like to PP to checks if in the PP folder we have a Show1.S01E01.mkv and Show1.S01E01.PROPER.mkv so if deletes the non-proper and only PP the "proper"
from medusa.
What i meant is to simply check if the same file trying to be PPed already beeing PPed since thats the only time issues arive ,no need to queue it
from medusa.
I guess we can adapt the decorator mii created to do just that? But what then? Return a failure to nzbToMedia, or a notification if it's a manual pp job?
from medusa.
Just return a "File is already beeing PPed" if its the same file, like it did with multiple threads
from medusa.
Hi,
could PP integrate the subs handling more properly?
I think about:
parsing files into PP temporary folder to detect embedded subs (most web-dl have embedded and get stuck in this folder because they are not detected)
enable auto PP for shows that don't require subs and also "delay PP if no subs" for show that need them (you can't have both settings at the same time at the moment).
from medusa.
@fernandog following the few discussions we had about it, you might be willing to comment
from medusa.
@NicoLeOca problem is embedded subs need the lang tag inside it. without it there is no way to know the lang.
from medusa.
@NicoLeOca i can remove the "auto PP" disabling when postpone if no subs. that will fix
from medusa.
@fernandog
please, that would fix one
about the embedded, the language could be detect by the name of the subs track, when the language flag is missing.
I know SR doesn't at the moment, but Plex does it's very successful.
I undestand that the files which have neither of the language name or the flag are impossible to detect though.
from medusa.
Plex uses the track lang, if there isnt any it defaults to english
from medusa.
thanks @duramato
I just made a few tests and you are right
let's forget it then
from medusa.
Added to master feature request list - discussion for feature will continue here even though issue is closed.
from medusa.
Related Issues (20)
- Vulnerability report contact person or email
- [APP SUBMITTED]: Missing time zone for network: bilibili
- [APP SUBMITTED]: Missing time zone for network: SYFY
- [APP SUBMITTED]: Missing time zone for network: Okoo
- [APP SUBMITTED]: Missing time zone for network: FOX Showcase
- [APP SUBMITTED]: Missing time zone for network: Yle TV1
- [APP SUBMITTED]: Missing time zone for network: Zues HOT 2
- [APP SUBMITTED]: Missing time zone for network: Zeus Network
- [APP SUBMITTED]: Missing time zone for network: U+ Mobile TV
- [APP SUBMITTED]: Missing time zone for network: FUSE TV
- [APP SUBMITTED]: Missing time zone for network: Channel 4+
- [APP SUBMITTED]: Missing time zone for network: CTV Comedy Channel
- [APP SUBMITTED]: Missing time zone for network: RTÉ2
- [APP SUBMITTED]: Missing time zone for network: Las Estrellas
- [APP SUBMITTED]: Missing time zone for network: Discovery Health Channel
- Mass Update root folder does not work properly
- [APP SUBMITTED]: Missing time zone for network: La 2
- [APP SUBMITTED]: Missing time zone for network: Channel News Asia
- Medusa Freeze/Unresponsive during nzbtomedia post process handling
- [APP SUBMITTED]: TypeError: '<' not supported between instances of 'NoneType' and 'datetime.datetime'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from medusa.