Ship a font for xkcd plots about pyodide

[nixphix]

Here's a one with permissive licence antiyawn

[rth]

Thanks @nixphix ! Would you like to make a Pull Request to add it?

[nixphix]

Sure will do

…

________________________________ From: Roman Yurchak <[email protected]> Sent: Monday, November 5, 2018 2:23 PM To: iodide-project/pyodide Cc: Prabakaran Kumaresshan; Mention Subject: Re: [iodide-project/pyodide] Ship a font for xkcd plots (#35) Thanks @nixphix<https://github.com/nixphix> ! Would you like to make a Pull Request to add it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#35 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEda6uHS-rf0zzJ8voi9ZRxPp6UmUBwRks5ur_yjgaJpZM4UItgU>.

[nixphix]

@rth could you give me some pointer on how to add the font asset

[rth]

I'm not exactly sure. There is a packages/matplotlib/src/fontList.json file that lists available fonts available under /lib/python3.7/site-packages/matplotlib/mpl-data in the virtual filesystem of the built package. My guess is that the matplolib setup would need to download this additional font and bundle it in somewhere in the filesystem, then one would need to add an entry to fontList.json. It's 25 kB font file, and not a frequently used one, so adding it needlessly to the main pyodide package is probably not optimal (though possibly acceptable).

@mdboom would have a better understanding of what needs to be done.

[rth]

Though the issue is that adding some custom asset is much easier e.g. for the main package (where one can just write the logic in a Makefile) than for a packaged python package (which uses the pyodide_build setup).

Maybe we could add something similar to the build->script entry in conda's meta.yaml, that would allow to run arbitrary code. For instance, here we would then use it to run some code to download this asset after patches are applied in matplotlib, but before the install process happens.

[madhur-tandon]

@mdboom @rth If no one is working on it, can I be assigned this perhaps? Moreover, can I have some starter tips as well?

[mdboom]

@madhur-tandon: I've assigned you. @rth's notes above are accurate. It basically needs to be added to the /lib/python3.7/site-packages/matplotlib/mpl-data directory at the time the package is built, and the fontList.json needs to be updated to refer to it. I think the extra size is reasonable -- it's probably not worth the complexity to have it in, for example, another package.

[madhur-tandon]

@mdboom @rth Made a PR for adding the font asset. Also, It is better to use the post entry in my opinion rather than the script entry in the build section of the meta.yaml file. The reasons for this are mentioned in the PR. I have also included a screenshot for the same as a proof that it works. Please let me know if this is feasible. I guess this is straightforward though.