Comments (2)
Thanks for opening the issue @WebReflection!
There was a similar discussion in pyodide/micropip#51, so the conclusion in this issue might also be applied to that one.
It's not very common to install modules at runtime, and even less common to uninstall them, so it's hard to say which way is better. It is also complicated by the fact that in Python, if an imported module is already in use, deleting it from sys.modules does not necessarily affect the module in use...
I am +1 with removing the module object from sys.modules when a module is re-registered / un-registered. This won't solve all of the problems, but it's somewhat close to "expected" behavior IMO.
from pyodide.
I am +1 with removing the module object from sys.modules when a module is re-registered / un-registered. This won't solve all of the problems, but it's somewhat close to "expected" behavior IMO.
yeah, expectations is all I am after ... I understand if stuff was previously referenced and never let go the FinalizationRegistry won't get ever a chance to free those resources but I really believe once an explicit unregisterJsModule
happens something must be different in further executions and, when a module is re-registered, something gotta happen ... either silently update the sys.modules
cache or throw an error because already used in the wild ... I am all for replacing it with the new updated references that any further script can consume, thanks for considering the issue and proposing your suggested changes!
from pyodide.
Related Issues (20)
- feat: Resolving CORS Restrictions in Node.js HOT 2
- please make it work like normal python HOT 1
- STATUS_BREAKPOINT on Microsoft Edge HOT 1
- NextJS build fails with webpack error due to Pyodide import HOT 1
- `OSError: [Errno 8] Bad file descriptor` when trying to save `.npy` files HOT 1
- `pyodide build -h` should print help text HOT 1
- dependcy for open-interpreter HOT 6
- `crc32c` HOT 4
- `zstandard` HOT 1
- pyodide build should read settings from pyproject.toml HOT 10
- webloop should support cancellation HOT 2
- Mac builds: Pyodide Venv: `pytest` breaks when `python -m pytest` does not HOT 10
- `Downloading Pyodide` slightly confusing for CDN usage HOT 1
- issue using pygame-ce HOT 12
- Pyodide config recipe broken in 0.26.0 HOT 3
- Add support for environment markers in dependency specifiers HOT 4
- Error when loading bundled python packages using Pyodide from NPM HOT 6
- scipy.integrate.dblquad gives very wrong result even for the simplest integrations HOT 21
- wrong behavior when setting item on a PyProxyJsonAdaptor HOT 2
- Wrong typing for `create_proxy` and `create_once_callable`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyodide.