GithubHelp home page GithubHelp logo

periodic_in_z not working about pysph HOT 3 CLOSED

pypr avatar pypr commented on July 28, 2024
periodic_in_z not working

from pysph.

Comments (3)

sankasuraj avatar sankasuraj commented on July 28, 2024

test_periodic_3dnnps.py.zip
Attaching a better test case

from pysph.

meyer-nils avatar meyer-nils commented on July 28, 2024

Lines 490 and 491 in nnps_base.pyx are as follows:
# reset the length of the arrays
x_low.reset(); x_high.reset(); y_high.reset(); y_low.reset()

I am pretty sure, one should add a reset for the z-component as well.
Changing it to
# reset the length of the arrays
x_low.reset(); x_high.reset(); y_low.reset(); y_high.reset()
z_low.reset(); z_high.reset()
resolved my issues with z-periodicity and successfully passes your tests. Note that you need to recompile cython files by running
python setup.py develop
again.

from pysph.

prabhuramachandran avatar prabhuramachandran commented on July 28, 2024

@sankasuraj -- thanks.
@nilsmeyerkit -- thanks, I'll fix this in master tonight.

from pysph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.