GithubHelp home page GithubHelp logo

Comments (5)

pyrossh avatar pyrossh commented on June 16, 2024

Well.. I thought it would be good to see which files are being loaded into the binary at compile time. That would make it easy to find out the progress of the compilation and also if some large file is taking too long. Does printing to stderr is a better approach or removing it altogether better. Anyways I'm ok with removing the println no one else has issues with it.

from rust-embed.

pyrossh avatar pyrossh commented on June 16, 2024

But will be 😭 as I have to remove the cool screenshots of my terminal from the readme.md

from rust-embed.

Boscop avatar Boscop commented on June 16, 2024

The include_bytes!() call should be very fast though, right?
It's not really "compiling" (processing) the included files..
So I think it's ok to have no output about this. People who are using rust-embed will know that if it takes a bit longer, it's because of the embedded files :)
I think a better solution is to just mention it in the Readme: "Be aware that compilation might take a little bit longer when embedding a large number of files."

from rust-embed.

pyrossh avatar pyrossh commented on June 16, 2024

Ok. You convinced me. And it seems no one is going to miss it. Do you want to raise a PR for it or should i do it.

from rust-embed.

Boscop avatar Boscop commented on June 16, 2024

I'm currently traveling on vacation with only my phone, so I think it'd be faster if you do it :)

from rust-embed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.