Comments (12)
(or maybe flake8 has a type checking plugin, I don't have a strong preference for a specific tool, just type checking in general)
flake8 doesn't do much on its own, it delegates the heavy work to other existing tools. There is a plugin for mypy as well, but I think it's better to use mypy directly. That one really only exists as a workaround for editors that have integrated flake8 support but no integration for mypy.
from toponetx.
I personally always use type annotations in my code, as it generally improves IDE support (suggestions, errors).
from toponetx.
what is your recommendation ?
from toponetx.
ok then, I will start addressing this issue then.
from toponetx.
I agree. In the medium term, I think we should also add mypy to the linters as it can easily detect some type errors (I just ran it manually and it found two mistakes that can be easily overlooked by humans, even with the limited type hinting currently present in the codebase)
from toponetx.
(or maybe flake8 has a type checking plugin, I don't have a strong preference for a specific tool, just type checking in general)
from toponetx.
It appears the discussion has a relatively clear outcome (so I changed the title of the issues). It seems, clear we should do it, but it is not a top-priority right now. However, we should probably add this as requirement for new commits.
from toponetx.
@ffl096 do you have updates on this? Should we close it?
from toponetx.
This is an ongoing effort and will be automatically closed once #163 is merged. The remaining issues are non-trivial and will take more time.
from toponetx.
@ffl096 when will you expect this to be completed?
from toponetx.
@ffl096 should we close this task ?
from toponetx.
See #163.
from toponetx.
Related Issues (20)
- Inconsistencies in `__getitem__` implementation across complex types
- Naming inconsistency: attributes vs. properties
- Inconsistencies in `__contains__` implementation across complex types HOT 2
- BUG in get_rank method in ColoredHyperEdgeView HOT 2
- Edge features of COSEG is a list of lists
- Edge Features of COSEG
- remove_singletons in ColoredHyperGraph throws error. HOT 2
- Unreachable code in ColoredHyperGraph, ColoredHyperGraphView, and CombinatorialComplex
- Switch from sparse matrices to sparse arrays
- Add `CITATION.cff` file after JMLR submission
- Breaking downstream change HOT 3
- Clarification of order-preserving rule for CCC HOT 1
- Definition of CCC and the logic that follows from it. HOT 11
- Package is breaking because of python version 3.12.0 HOT 2
- pyproject.toml not enforcing build constraints
- Docstrings Missing HOT 1
- Changing lint and formatter HOT 6
- Import Convention for TopoNetX HOT 1
- Invalid return type for disconnected elements in `algorithms.distance` module
- OFF files to NPZ files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from toponetx.