Comments (2)
The following response was emailed to the ticket creator on April 25, 2011.:
Finally saw your ticket. Due to various reasons, we have just started using my github account to track issues. If you file a ticket or, even better, do a pull request, I won't forget about it.
A few comments about your changes. I've always wanted to rip out the old (pre logging) message wrapper. Glad to see it gone. However, I am unsure about not raising UnicodeDecodeError without a custom message. Based on past experience, I expect we'll get repeated bug reports asking to build in support for whatever non-unicode input that failed. Explicitly stating we won't in the message seems to have curtailed such requests.
I'm also not sure that we should completely remove all the error/warning related tests. Sure, the 2 tests that directly test the message function should go, but I would rather see the rest altered so that they pass with the changes.
Oh, and for the record, I anticipate releasing 2.1 soonish. I see it more as "what 2.0 should have been." There are already a few small backward compatibilities. Nothing that the average user will notice. But extension authors may need to make a few adjustments. Might as well include this while we're at it.
Speaking of extensions, I noticed that your changes raise an error on a problem header, while the base implementation logs a warning. The behavior should be consistent.
Which brings me to a question: You said you were getting a error should problem headers. That shouldn't be happening. Any idea what was causing the problem?
from markdown.
Fixed in 08b9b6f
from markdown.
Related Issues (20)
- Does not handle comments in code snippets HOT 2
- Python Markdown turns `</#rrggbb>` into HTML comment, even while in inline code HOT 11
- bug(md_in_html): “markdown="1"” isn’t removed in child elements of the “li” tag HOT 4
- 3.5.2: pytest fails HOT 8
- Tables in blockquotes with nl2br extension HOT 2
- API docs are not being properly indexed for search HOT 18
- Strange and inconsistent parsing of lists with headers and multiple lines HOT 6
- The title from `toc_tokens` ignores the `smarty` extension HOT 3
- BlockProcessor output wrapped in p tag HOT 9
- Trying to migrate from `markdown2`, lists without blank lines not working HOT 3
- "Unterminated character set" exception when using extra extension HOT 6
- <table> improperly wrapped by <p> when inside a list HOT 1
- Add Support for Tab Customization in Code Blocks HOT 3
- List not rendering correctly when preceded by word HOT 1
- add a buildin Mermaid extention HOT 1
- No table support? HOT 8
- GFM alerts HOT 2
- TOC extension: ignore headers above [TOC] marker HOT 2
- Fenced code blocks with newlines not parsed into html <code> blocks HOT 2
- convert \u2028 to <br>? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from markdown.