GithubHelp home page GithubHelp logo

Clean up logging. about markdown HOT 2 CLOSED

python-markdown avatar python-markdown commented on May 25, 2024
Clean up logging.

from markdown.

Comments (2)

waylan avatar waylan commented on May 25, 2024

The following response was emailed to the ticket creator on April 25, 2011.:

Finally saw your ticket. Due to various reasons, we have just started using my github account to track issues. If you file a ticket or, even better, do a pull request, I won't forget about it.

A few comments about your changes. I've always wanted to rip out the old (pre logging) message wrapper. Glad to see it gone. However, I am unsure about not raising UnicodeDecodeError without a custom message. Based on past experience, I expect we'll get repeated bug reports asking to build in support for whatever non-unicode input that failed. Explicitly stating we won't in the message seems to have curtailed such requests.

I'm also not sure that we should completely remove all the error/warning related tests. Sure, the 2 tests that directly test the message function should go, but I would rather see the rest altered so that they pass with the changes.

Oh, and for the record, I anticipate releasing 2.1 soonish. I see it more as "what 2.0 should have been." There are already a few small backward compatibilities. Nothing that the average user will notice. But extension authors may need to make a few adjustments. Might as well include this while we're at it.

Speaking of extensions, I noticed that your changes raise an error on a problem header, while the base implementation logs a warning. The behavior should be consistent.

Which brings me to a question: You said you were getting a error should problem headers. That shouldn't be happening. Any idea what was causing the problem?

from markdown.

waylan avatar waylan commented on May 25, 2024

Fixed in 08b9b6f

from markdown.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.