Best practices for integration with other asyncio libraries? about websockets

[aaugustin]

asyncio.wait is The Right Way as far as I know. I'm using it in websockets: https://github.com/aaugustin/websockets/blob/43d334f4e19e2a9755c44448b47fa8ff07e9b0fb/websockets/protocol.py#L161-L168

I didn't hit the same issue as you because I'm wrapping the coroutine with asyncio.async so it's a task already and asyncio doesn't wrap it.

I'm not sure there's a better way. I would suggest asking on the python-tulip mailing list: https://groups.google.com/forum/#!forum/python-tulip

I'm subscribed to this list and I'll jump in the discussion if I have something to say. In the mean time, I'll close this ticket because this is really a general issue with asyncio and not a specific issue with websockets.

Thanks for taking the time to report it anyway!

[donspaulding]

Thanks Aymeric, for taking the time to explain and point me in the right direction.  I've raised the issue on python-tulip and will see how that goes.

Thanks also for your work on websockets (and Django 1.7!).  I know the work can sometimes be thankless, but I really appreciate your efforts to create elegant APIs.

😃
—
Don

On Tue, Nov 11, 2014 at 2:00 PM, Aymeric Augustin
[email protected] wrote:

asyncio.wait is The Right Way as far as I know. I'm using it in websockets: https://github.com/aaugustin/websockets/blob/43d334f4e19e2a9755c44448b47fa8ff07e9b0fb/websockets/protocol.py#L161-L168
I didn't hit the same issue as you because I'm wrapping the coroutine with asyncio.async so it's a task already and asyncio doesn't wrap it.
I'm not sure there's a better way. I would suggest asking on the python-tulip mailing list: https://groups.google.com/forum/#!forum/python-tulip
I'm subscribed to this list and I'll jump in the discussion if I have something to say. In the mean time, I'll close this ticket because this is really a general issue with asyncio and not a specific issue with websockets.

Thanks for taking the time to report it anyway!

Reply to this email directly or view it on GitHub:
#37 (comment)

[aaugustin]

For the record, Guido recommends the pattern I ended up with:
https://groups.google.com/d/msg/python-tulip/_a_578xox28/3Ku2jmH18-sJ