GithubHelp home page GithubHelp logo

Comments (7)

bbangert avatar bbangert commented on August 17, 2024

What behavior is expected when watching a node that doesn't exist? Immediate error? Silently ignored until it does exist?

from kazoo.

nekto0n avatar nekto0n commented on August 17, 2024

Not sure. We already have immediate error on first call. What are the choices?

  1. Don't set session listener if first read failed.
  2. Silently ignore.
  3. Raise error every time (immediate and deferred)

I think current implementation is wrong anyway - it blocks session events until _get_data returns and docs say that users should avoid doing that.

Hm... How zookeeper behaves if watched node being removed? How does Curator handles this situation?

from kazoo.

bbangert avatar bbangert commented on August 17, 2024

Curator doesn't have any functionality that matches the DataWatch. If the node is deleted, or can't be found on a reconnect, those could just be ignored and if it exists again, and the children are different that before, it calls the function.

from kazoo.

nekto0n avatar nekto0n commented on August 17, 2024

You mean DataWatch must keep both exists and get watches? If you expose exists method from DataWatch class (which should be a simple cached boolean flag) - that should work.

from kazoo.

nekto0n avatar nekto0n commented on August 17, 2024

... but removing node causes it's content change, so user must be notified.

from kazoo.

bbangert avatar bbangert commented on August 17, 2024

Yep, makes sense. I think it'd be easiest if None was delivered in the event that its removed, since the values have to be string we can use None safely to indicate there is no longer a node.

from kazoo.

nekto0n avatar nekto0n commented on August 17, 2024

Thanks!

from kazoo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.