List index out of range in ConnectionHandler._write about kazoo

[hannosch]

I've committed a patch for this. The select.select call doesn't raise a timeout exception, but simply returns with three empty lists to signal the error case. I'm raising an explicit handler specific timeout exception instead now. I'm not entirely sure if this works or if more special handling is required. Feedback welcome.

[blackwithwhite666]

Thank you. I will try this path in next few days.

[blackwithwhite666]

Now, i got new exception:

Exception in thread Thread-14:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/threading.py", line 551, in __bootstrap_inner
    self.run()
  File "/usr/local/lib/python2.7/threading.py", line 504, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/home/user/venv/lib/python2.7/site-packages/kazoo/protocol/connection.py", line 400, in writer
    if self._connect_loop(retry) is False:
  File "/home/user/venv/lib/python2.7/site-packages/kazoo/protocol/connection.py", line 444, in _connect_loop
    connect_timeout)
  File "/home/user/venv/lib/python2.7/site-packages/kazoo/protocol/connection.py", line 572, in _send_request
    self._submit(Ping, connect_timeout, PING_XID)
  File "/home/user/venv/lib/python2.7/site-packages/kazoo/protocol/connection.py", line 227, in _submit
    self._write(int_struct.pack(len(b)) + b, timeout)
  File "/home/user/venv/lib/python2.7/site-packages/kazoo/protocol/connection.py", line 242, in _write
    raise self.handler.timeout_exception("socket time-out")
TimeoutError: socket time-out

Should we try to reconnect to zookeeper server in _ConnectionHandler::connect_loop? Also, listeners (added with add_listener) didn't receive any events in this case.

[nekto0n]

I think _connect_loop should try like forever until it stopped explicitly. Right now it quits when .retry raises en error.

[hannosch]

The _write issue should be fixed now, but I'll write a test for read timeouts as well. The same problem should exist there.

[hannosch]

I added the test for socket timeouts in _read. Currently the reader thread shuts down on those (hitting the except Exception as e: at the end of the while True loop in the reader method.

Nothing seems to try to set up a new reader thread, and the original client.get call just deadlocks :-(